From: Anthony Liguori <anthony@codemonkey.ws>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7
Date: Fri, 09 Mar 2012 13:27:37 -0600 [thread overview]
Message-ID: <4F5A59A9.2060604@codemonkey.ws> (raw)
In-Reply-To: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
On 03/02/2012 09:49 AM, Hans de Goede wrote:
> VCARD_ATR_PREFIX is used as part of an array initializer so it should
> not have () around it, so far this happened to work, but gcc-4.7 does
> not like it.
>
> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> libcacard/vcardt.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d4d8e2e..d3e9522 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
> #define MAX_CHANNEL 4
>
> /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> - 'V', 'C', 'A', 'R', 'D', '_')
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> + 'V', 'C', 'A', 'R', 'D', '_'
>
>
> typedef enum {
prev parent reply other threads:[~2012-03-09 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 15:49 [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7 Hans de Goede
2012-03-03 1:44 ` Brad Smith
2012-03-05 12:47 ` Alon Levy
2012-03-05 12:50 ` Alon Levy
2012-03-05 13:06 ` Michal Privoznik
2012-03-06 13:31 ` Alon Levy
2012-03-09 19:27 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A59A9.2060604@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.