From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Christopher R. Hertel" Subject: Re: [PATCH 06/11] CIFS: Respect MaxMpxCount field Date: Fri, 09 Mar 2012 15:07:56 -0600 Message-ID: <4F5A712C.8030500@samba.org> References: <1329895984-9251-1-git-send-email-piastry@etersoft.ru> <1329895984-9251-7-git-send-email-piastry@etersoft.ru> <20120303070921.5ce2bb10@tlielax.poochiereds.net> <20120309073930.3a79fa10@redhat.com> <4F5A543D.2040808@samba.org> <20120309201439.GH9348@samba2> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeremy Allison , Jeff Layton , Pavel Shilovsky , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve French Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 03/09/2012 02:16 PM, Steve French wrote: > On Fri, Mar 9, 2012 at 2:14 PM, Jeremy Allison wrote: >> On Fri, Mar 09, 2012 at 01:04:29PM -0600, Christopher R. Hertel wrote: >>> >>> The folks at Microsoft (who are, of course, well ahead in their >>> SMB2.x implementations) are very surprised that we are trying to >>> maintain a single codebase for both protocols. (I heard the same >>> thing from several Microsoft engineers during separate >>> conversations.) >> >> That's just a misunderstanding of how our codebase is >> structured, that's all. >> >> The SMB1 parser/protocol engine is completely different code from the SMB2 >> parser/protocol engine in Samba. >> >> What is in common (as is also in common in Microsoft's codebase) >> is the code that implements the underlying file system functionality. >> >> They have a common NTFS (and now ReFS) codebase, we have a common >> map POSIX to Windows semantics layer. > > On the client side, as a compromise with those who wanted one module, > (ie in Pavel's tree) we keep the majority of the smb2 specific code in > distinct c files > which are not linked in by default to cifs.ko. Sharing the same transport code > does have headaches though as the discussion above mentions with regard > to "credits" vs. "maxmpx" but it has turned out better than I originally > expected (ie the changes to common code) No doubt. ...and we certainly want only one piece of code actually creating and managing connections to the server. -- "Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X Samba Team -- http://www.samba.org/ -)----- Christopher R. Hertel jCIFS Team -- http://jcifs.samba.org/ -)----- ubiqx development, uninq. ubiqx Team -- http://www.ubiqx.org/ -)----- crh-jFlgvBokg3lg9hUCZPvPmw@public.gmane.org OnLineBook -- http://ubiqx.org/cifs/ -)----- crh-zuGDro9SezXYtjvyW6yDsg@public.gmane.org