All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Michal Privoznik <mprivozn@redhat.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] perf: compare diff algorithms
Date: Sat, 10 Mar 2012 08:13:55 +0100	[thread overview]
Message-ID: <4F5AFF33.7090900@lsrfire.ath.cx> (raw)
In-Reply-To: <f113867bcf2fec3210cd1a997e1398903b3bdd76.1331039505.git.trast@student.ethz.ch>

Am 06.03.2012 14:15, schrieb Thomas Rast:
> 8c912ee (teach --histogram to diff, 2011-07-12) claimed histogram diff
> was faster than both Myers and patience.
>
> We have since incorporated a performance testing framework, so add a
> test that compares the various diff tasks performed in a real 'log -p'
> workload.  This does indeed show that histogram diff slightly beats
> Myers, while patience is much slower than the others.
>
> Signed-off-by: Thomas Rast<trast@student.ethz.ch>
> ---
>
> The 3000 is pretty arbitrary but makes for a nice test duration.
>
> I'm reluctant to put numbers into the message, since the whole point
> of the perf test framework is that you can easily get them too.  But
> here's what I'm seeing:
>
>    4000.1: log -3000 (baseline)          0.04(0.02+0.01)
>    4000.2: log --raw -3000 (tree-only)   0.49(0.38+0.09)
>    4000.3: log -p -3000 (Myers)          1.93(1.75+0.17)
>    4000.4: log -p -3000 --histogram      1.90(1.74+0.15)
>    4000.5: log -p -3000 --patience       2.25(2.07+0.16)

Just a data point: --histogram is slightly slower for me:

    Test                                  this tree
    -----------------------------------------------------
    4000.1: log -3000 (baseline)          0.07(0.07+0.00)
    4000.2: log --raw -3000 (tree-only)   0.35(0.31+0.04)
    4000.3: log -p -3000 (Myers)          1.50(1.40+0.08)
    4000.4: log -p -3000 --histogram      1.54(1.48+0.05)
    4000.5: log -p -3000 --patience       1.79(1.71+0.06)

(baseline with -3000)

René

  parent reply	other threads:[~2012-03-10  7:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 10:59 [PATCH] config: Introduce --patience config variable Michal Privoznik
2012-03-06 11:49 ` Jeff King
2012-03-06 13:01   ` Thomas Rast
2012-03-06 13:15     ` [PATCH 1/2] perf: compare diff algorithms Thomas Rast
2012-03-06 13:15       ` [PATCH 2/2] Document the --histogram diff option Thomas Rast
2012-03-06 19:57         ` Junio C Hamano
2012-03-06 20:42           ` Thomas Rast
2012-03-06 19:52       ` [PATCH 1/2] perf: compare diff algorithms Junio C Hamano
2012-03-06 21:00         ` Thomas Rast
2012-03-06 21:18           ` Junio C Hamano
2012-03-06 21:41             ` Jakub Narebski
2012-03-07 12:44               ` Thomas Rast
2012-03-07 17:45                 ` Junio C Hamano
2012-03-07 18:03                 ` Jakub Narebski
2012-03-07 18:19                   ` Junio C Hamano
2012-03-10  7:13       ` René Scharfe [this message]
2012-03-06 13:30     ` [PATCH] config: Introduce --patience config variable Jeff King
2012-03-06 13:32     ` Michal Privoznik
2012-03-06 13:38       ` Matthieu Moy
2012-03-06 14:09         ` Jeff King
2012-03-07  2:57   ` Junio C Hamano
2012-03-07 11:47     ` Jeff King
2012-03-07 17:24       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5AFF33.7090900@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mprivozn@redhat.com \
    --cc=peff@peff.net \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.