From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6L8a-0003Lq-Ic for qemu-devel@nongnu.org; Sat, 10 Mar 2012 07:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6L8Y-0007zy-Ll for qemu-devel@nongnu.org; Sat, 10 Mar 2012 07:11:04 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52382 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6L8Y-0007zl-Fe for qemu-devel@nongnu.org; Sat, 10 Mar 2012 07:11:02 -0500 Message-ID: <4F5B44D4.5030105@suse.de> Date: Sat, 10 Mar 2012 13:11:00 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331374472-15157-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1331374472-15157-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] w64: Don't redefine lseek, ftruncate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org Am 10.03.2012 11:14, schrieb Stefan Weil: > MinGW-w64 already defines lseek and ftruncate (and uses the 64 bit > variants). The conditional compilation avoids redefinitions > (which would be wrong) and compiler warnings. >=20 > Signed-off-by: Stefan Weil > --- > qemu-common.h | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/qemu-common.h b/qemu-common.h > index dbfce6f..b0fdf5c 100644 > --- a/qemu-common.h > +++ b/qemu-common.h > @@ -93,9 +93,13 @@ typedef int (*fprintf_function)(FILE *f, const char = *fmt, ...) > =20 > #ifdef _WIN32 > #define fsync _commit > -#define lseek _lseeki64 > +#if !defined(lseek) > +# define lseek _lseeki64 > +#endif > int qemu_ftruncate64(int, int64_t); > -#define ftruncate qemu_ftruncate64 > +#if !defined(ftruncate) > +# define ftruncate qemu_ftruncate64 > +#endif lseek looks okay to me, but did you check that ftruncate and qemu_ftruncate64 behave the same? Andreas > =20 > static inline char *realpath(const char *path, char *resolved_path) > { --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg