From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S6QRn-0005BH-N5 for mharc-grub-devel@gnu.org; Sat, 10 Mar 2012 12:51:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6QRl-0005Ad-3G for grub-devel@gnu.org; Sat, 10 Mar 2012 12:51:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6QRi-0003J6-RQ for grub-devel@gnu.org; Sat, 10 Mar 2012 12:51:12 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:44912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6QRi-0003IW-Ii for grub-devel@gnu.org; Sat, 10 Mar 2012 12:51:10 -0500 Received: by wibhj13 with SMTP id hj13so1461252wib.12 for ; Sat, 10 Mar 2012 09:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=jJw+oSC68MPHY6dv11xF7RE9AD6ir4E3evZ74XYiKiU=; b=UDMn+Uly1GOSxjQHiCN7/FWe9IZzgRI/aH3XjLZHZpmMjOAiCjZtJhgg3debNnosc/ yFeLrrACEz8fabXaoliC7uSrUa0GC1umYfSKpFtF4eSWTic6PXoZQSdkFR/QRvwhaByh +8ic57MEeIA5er3KVbhuwYcOtomw9aWRxJGUw5iaypVYSK2euKq7mFat3mwa8OOw+v7T iXTTqpxNYBJ1UbBnDj1ll1b3hzr0iWpsgxyiAOq2oeeLapcP/xgDGql/IwMlOKGAyj+Y y3Hy50ons54KQfXFaSV19NVlhUEVLwDZJbcDxGBVfMIR4VQCI4MrFKUYCWdmSxCh/cKu vsAw== Received: by 10.216.134.41 with SMTP id r41mr3953641wei.13.1331401868312; Sat, 10 Mar 2012 09:51:08 -0800 (PST) Received: from fedora.x201.phnet (207-116.62-81.cust.bluewin.ch. [81.62.116.207]) by mx.google.com with ESMTPS id dw7sm16406531wib.4.2012.03.10.09.51.06 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 10 Mar 2012 09:51:07 -0800 (PST) Message-ID: <4F5B9489.5090505@gmail.com> Date: Sat, 10 Mar 2012 18:51:05 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Richard Laager Subject: Re: Remaining ZFS Changes for 2.00 (Was: Re: Freeze on 27 February) References: <4F43C25C.2040106@gmail.com> <1329888906.16648.134.camel@watermelon.coderich.net> <4F45DDF0.2090908@gmail.com> <1330033617.3895.26.camel@watermelon.coderich.net> <4F4AC782.1090402@gmail.com> <1330322499.2901.5.camel@watermelon.coderich.net> <4F4BC95C.5040706@gmail.com> <1330371970.2901.34.camel@watermelon.coderich.net> <1331247110.6821.26.camel@watermelon.coderich.net> In-Reply-To: <1331247110.6821.26.camel@watermelon.coderich.net> X-Enigmail-Version: 1.3.5 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigD2D8F272347DB850D5922B9C" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.171 Cc: The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 17:51:14 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD2D8F272347DB850D5922B9C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08.03.2012 23:51, Richard Laager wrote: > I believe the following change is still needed to support pool names > with spaces. That said, maybe we shouldn't care about pool names with > spaces. If a pool name has spaces, then we need some way to escape it > when building the linux_entry command line. Then the initrd needs to > unescape it. That seems like a lot of hassle for a configuration that's= > likely to be extremely uncommon even if GRUB does support it. > > Index: grub/util/getroot.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- grub.orig/util/getroot.c 2012-02-03 05:21:06.838056692 -0600 > +++ grub/util/getroot.c 2012-02-03 05:22:36.227364000 -0600 > @@ -285,8 +285,7 @@ > st++; > break; > case 1: > - if (!strcmp (name, poolname)) > - st++; > + st++; > The root cause of the problem is that sscanf on the top of this loop is improper way to parse strings with spaces so probably this will create more problems e.g. if for some reason we have an extra empty line. Also if a space is present if member devices e're back to the same problem. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigD2D8F272347DB850D5922B9C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk9blIkACgkQNak7dOguQgn+FgEAjJKi1sEMMYG+qMOEpotu+uhb Ja/Hvk2yP+QeDtJYzmkA/iDzUUGnxqrt42qTmUAEKvwoHGXVu3/ye61WfqHC1XUm =JMc6 -----END PGP SIGNATURE----- --------------enigD2D8F272347DB850D5922B9C--