From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S6Rqo-00055b-7M for mharc-qemu-trivial@gnu.org; Sat, 10 Mar 2012 14:21:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6Rql-0004yq-Nk for qemu-trivial@nongnu.org; Sat, 10 Mar 2012 14:21:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6Rqk-00020q-0b for qemu-trivial@nongnu.org; Sat, 10 Mar 2012 14:21:07 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:59286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6Rqg-0001zw-DU; Sat, 10 Mar 2012 14:21:02 -0500 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 4E47A72800A0; Sat, 10 Mar 2012 20:21:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 110V1QeU0a79; Sat, 10 Mar 2012 20:20:59 +0100 (CET) Received: from flocke.weilnetz.de (p5086F01F.dip.t-dialin.net [80.134.240.31]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 95370728009F; Sat, 10 Mar 2012 20:20:59 +0100 (CET) Received: from localhost ([127.0.0.1] ident=stefan) by flocke.weilnetz.de with esmtp (Exim 4.72) (envelope-from ) id 1S6Rqc-0001jn-Rr; Sat, 10 Mar 2012 20:20:58 +0100 Message-ID: <4F5BA99A.9000105@weilnetz.de> Date: Sat, 10 Mar 2012 20:20:58 +0100 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Paul Brook References: <1330177825-7618-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1330177825-7618-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 78.47.199.172 Cc: qemu-trivial , Anthony Liguori , qemu-devel@nongnu.org, jforbes@redhat.com Subject: Re: [Qemu-trivial] [PATCH] ds1338: Add missing break statement X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 19:21:09 -0000 Am 25.02.2012 14:50, schrieb Stefan Weil: > Without the break statement, case 5 sets month and year from the same > data. This does not look correct. > > The missing break was reported by splint. > > Signed-off-by: Stefan Weil > --- > hw/ds1338.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/ds1338.c b/hw/ds1338.c > index 6397f0a..d590d9c 100644 > --- a/hw/ds1338.c > +++ b/hw/ds1338.c > @@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) > break; > case 5: > s->now.tm_mon = from_bcd(data & 0x1f) - 1; > + break; > case 6: > s->now.tm_year = from_bcd(data) + 100; > break; Ping. This is a simple bug fix. It was reviewed by Peter Maydell (thanks!). Could someone please commit it to QEMU master (maybe to stable-1.0, too)? Regards, Stefan Weil From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6Rqi-0004yP-JC for qemu-devel@nongnu.org; Sat, 10 Mar 2012 14:21:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6Rqg-00020H-Kg for qemu-devel@nongnu.org; Sat, 10 Mar 2012 14:21:04 -0500 Message-ID: <4F5BA99A.9000105@weilnetz.de> Date: Sat, 10 Mar 2012 20:20:58 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1330177825-7618-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1330177825-7618-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ds1338: Add missing break statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-trivial , Anthony Liguori , qemu-devel@nongnu.org, jforbes@redhat.com Am 25.02.2012 14:50, schrieb Stefan Weil: > Without the break statement, case 5 sets month and year from the same > data. This does not look correct. > > The missing break was reported by splint. > > Signed-off-by: Stefan Weil > --- > hw/ds1338.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/ds1338.c b/hw/ds1338.c > index 6397f0a..d590d9c 100644 > --- a/hw/ds1338.c > +++ b/hw/ds1338.c > @@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) > break; > case 5: > s->now.tm_mon = from_bcd(data & 0x1f) - 1; > + break; > case 6: > s->now.tm_year = from_bcd(data) + 100; > break; Ping. This is a simple bug fix. It was reviewed by Peter Maydell (thanks!). Could someone please commit it to QEMU master (maybe to stable-1.0, too)? Regards, Stefan Weil