diff for duplicates of <4F5D9002.1030505@ti.com> diff --git a/a/1.txt b/N1/1.txt index 2335de0..0344a78 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -147,13 +147,14 @@ On Sunday 11 March 2012 09:04 PM, Grazvydas Ignotas wrote: > --- a/drivers/video/omap2/dss/core.c > +++ b/drivers/video/omap2/dss/core.c > @@ -434,6 +434,12 @@ int omap_dss_register_driver(struct omap_dss_driver *dssdriver) -> if (dssdriver->get_recommended_bpp = NULL) -> dssdriver->get_recommended_bpp > omapdss_default_get_recommended_bpp; -> + if (dssdriver->set_timings = NULL) +> if (dssdriver->get_recommended_bpp == NULL) +> dssdriver->get_recommended_bpp = +> omapdss_default_get_recommended_bpp; +> + if (dssdriver->set_timings == NULL) > + dssdriver->set_timings = omapdss_default_set_timings; -> + if (dssdriver->get_timings = NULL) +> + if (dssdriver->get_timings == NULL) > + dssdriver->get_timings = omapdss_default_get_timings; -> + if (dssdriver->check_timings = NULL) +> + if (dssdriver->check_timings == NULL) > + dssdriver->check_timings = omapdss_default_check_timings; This elimination makes sense with get_timings(), but having the default @@ -167,7 +168,7 @@ set_timings(), it would mess up the DSS2 driver. Probably having a check like this in check_timings()/set_timings() might make it safer: -if (dssdev->type = OMAP_DISPAY_TYPE_DPI) +if (dssdev->type == OMAP_DISPAY_TYPE_DPI) dpi_set_timings(dssdev, timings); Regards, diff --git a/a/content_digest b/N1/content_digest index 7bfa28e..41fdf82 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01331480061-5767-1-git-send-email-notasas@gmail.com\0" "From\0Archit Taneja <a0393947@ti.com>\0" "Subject\0Re: [PATCH] OMAPDSS: provide default timings functions for panels\0" - "Date\0Mon, 12 Mar 2012 05:57:32 +0000\0" + "Date\0Mon, 12 Mar 2012 11:26:18 +0530\0" "To\0Grazvydas Ignotas <notasas@gmail.com>\0" "Cc\0linux-fbdev@vger.kernel.org" Tomi Valkeinen <tomi.valkeinen@ti.com> @@ -157,13 +157,14 @@ "> --- a/drivers/video/omap2/dss/core.c\n" "> +++ b/drivers/video/omap2/dss/core.c\n" "> @@ -434,6 +434,12 @@ int omap_dss_register_driver(struct omap_dss_driver *dssdriver)\n" - "> \tif (dssdriver->get_recommended_bpp = NULL)\n" - "> \t\tdssdriver->get_recommended_bpp > \t\t\tomapdss_default_get_recommended_bpp;\n" - "> +\tif (dssdriver->set_timings = NULL)\n" + "> \tif (dssdriver->get_recommended_bpp == NULL)\n" + "> \t\tdssdriver->get_recommended_bpp =\n" + "> \t\t\tomapdss_default_get_recommended_bpp;\n" + "> +\tif (dssdriver->set_timings == NULL)\n" "> +\t\tdssdriver->set_timings = omapdss_default_set_timings;\n" - "> +\tif (dssdriver->get_timings = NULL)\n" + "> +\tif (dssdriver->get_timings == NULL)\n" "> +\t\tdssdriver->get_timings = omapdss_default_get_timings;\n" - "> +\tif (dssdriver->check_timings = NULL)\n" + "> +\tif (dssdriver->check_timings == NULL)\n" "> +\t\tdssdriver->check_timings = omapdss_default_check_timings;\n" "\n" "This elimination makes sense with get_timings(), but having the default \n" @@ -177,7 +178,7 @@ "Probably having a check like this in check_timings()/set_timings() might \n" "make it safer:\n" "\n" - "if (dssdev->type = OMAP_DISPAY_TYPE_DPI)\n" + "if (dssdev->type == OMAP_DISPAY_TYPE_DPI)\n" "\tdpi_set_timings(dssdev, timings);\n" "\n" "Regards,\n" @@ -261,4 +262,4 @@ "> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);\n" > int omap_dispc_register_isr(omap_dispc_isr_t isr, void *arg, u32 mask); -38a3365010187397f6ecc7e12f8b3dbd35eed82a2aa9eef4a93aaf53ac83b41a +889a2821bcd4d2841817c643fdc4366dfa4c4a9ad687666e052a52ff21e54e6e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.