From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namhyung Kim Subject: Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2) Date: Mon, 12 Mar 2012 16:43:27 +0900 Message-ID: <4F5DA91F.7060908@lge.com> References: <1331160079-13821-1-git-send-email-asharma@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:59368 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882Ab2CLHnb (ORCPT ); Mon, 12 Mar 2012 03:43:31 -0400 In-Reply-To: <1331160079-13821-1-git-send-email-asharma@fb.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Arun Sharma Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Stephane Eranian , Tom Zanussi , linux-perf-users@vger.kernel.org Hi, 2012-03-08 7:41 AM, Arun Sharma wrote: > This patch series refactors existing code a bit and adds sort by > inclusive time (time spent in the function + callees). > > Sample command lines: > > # perf record -ag -- sleep 1 > # perf report -g graph,0.5,callee -n -s inclusive > > Known bugs: > > total_period computation is broken for order=callee > I'd like to add two more :). * If perf record misses callchain info, perf report will get stuck. * If it's used with "symbol" sort order, it'll get stuck too. BTW, I don't like the name 'inclusive' as a sort key. If it cares about time, IMHO, the name should contain 'time' - something like 'itime' or 'inctime'? Furthermore, I don't think it is a sort key. As it doesn't sort anything, and only affects the way calculating symbol's period value, wouldn't it be better making it a separate switch rather than a sort key? Plus, checking whether it has callchain data and symbol sort key might be added also. Thanks, Namhyung