From: cpebenito@tresys.com (Christopher J. PeBenito)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH v2 1/1] Support LDAP backend infrastructure
Date: Mon, 12 Mar 2012 09:11:35 -0400 [thread overview]
Message-ID: <4F5DF607.404@tresys.com> (raw)
In-Reply-To: <4F5DF5A5.7000104@tresys.com>
On 03/12/12 09:09, Christopher J. PeBenito wrote:
> On 03/06/12 15:54, Sven Vermeulen wrote:
>> On Tue, Mar 06, 2012 at 09:10:22PM +0100, Sven Vermeulen wrote:
>>>>> @@ -68,6 +74,7 @@ corenet_tcp_bind_generic_node(dhcpd_t)
>>>>> corenet_udp_bind_generic_node(dhcpd_t)
>>>>> corenet_tcp_bind_dhcpd_port(dhcpd_t)
>>>>> corenet_udp_bind_dhcpd_port(dhcpd_t)
>>>>> +corenet_udp_bind_generic_port(dhcpd_t)
>>>>
>>>> Looks like a port needs to be defined.
>>>
>>> Not really, but the call should be corenet_udp_bind_all_unreserved_ports,
>>> not corenet_udp_bind_generic_port. Guess I'll have to go for personal
>>> testing more than to accept an "it works" on a bugreport :p
>
> Sounds like the above is the change we need. Please also add a comment that describes what you found below, so we can remember it next time this comes up.
To clarify: a comment in the policy, not just in the commit message.
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
prev parent reply other threads:[~2012-03-12 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 20:02 [refpolicy] [PATCH v2 1/1] Support LDAP backend infrastructure Sven Vermeulen
2012-03-06 14:06 ` Christopher J. PeBenito
2012-03-06 20:10 ` Sven Vermeulen
2012-03-06 20:54 ` Sven Vermeulen
2012-03-12 13:09 ` Christopher J. PeBenito
2012-03-12 13:11 ` Christopher J. PeBenito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5DF607.404@tresys.com \
--to=cpebenito@tresys.com \
--cc=refpolicy@oss.tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.