From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Mathieu_Gagn=E9?= Subject: Re: Volunteers required for 4.2 TODO items (Re: 4.2 TODO update) Date: Mon, 12 Mar 2012 12:00:04 -0400 Message-ID: <4F5E1D84.7050100@iweb.com> References: <1331554278.23971.63.camel@zakaz.uk.xensource.com> <1331554940.23971.72.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331554940.23971.72.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 3/12/12 8:22 AM, Ian Campbell wrote: > On Mon, 2012-03-12 at 12:11 +0000, Ian Campbell wrote: >> There are several things below which are in need of a volunteer to take care of them... > > Specifically: > >> tools, nice to have: >> * support for vif "rate" parameter (No one, AFAICT) > I'm working on a patch to add support for vif rate limiting in libxl. I don't have much experience with C and my knowledge is limited. (although I develop in other languages) At this moment, I only have a "proof of concept" with a main function so I can play and do tests to verify the parsing/results. (bytes_per_interval,interval_usecs) I would have a couple of questions about how to integrate the feature/code within libxl/xl. The rate syntax requires relatively complex parsing which would require at least 3 new functions which could all be combined in one if required. (parse_vif_rate, parse_vif_rate_bytes_per_sec and parse_vif_rate_interval_usecs) Where should those functions be added? xl_cmdimpl.c? What should be the names of the new struct members of libxl_device_nic? I same some "suggestions" in the previous rejected patch [1]. Are those names good? Should they be closer to the concept of "rate" instead of "qos"? Also, should more information be provided to the user about the rate syntax? rate= isn't that useful. Thanks! [1] http://lists.xen.org/archives/html/xen-devel/2011-03/msg01963.html -- Mathieu