All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gianluca Gennari <gennarone@gmail.com>
To: Hans-Frieder Vogt <hfvogt@gmx.net>, linux-media@vger.kernel.org
Subject: Re: [PATCH] AF903X driver update, v1.02
Date: Mon, 12 Mar 2012 18:10:49 +0100	[thread overview]
Message-ID: <4F5E2E19.4010208@gmail.com> (raw)
In-Reply-To: <201203111623.04475.hfvogt@gmx.net>

Il 11/03/2012 16:23, Hans-Frieder Vogt ha scritto:
> This is an update of the patch "Basic AF9035/AF9033 driver" that I send to the mailing list on 22 Feb.
> The driver provides support for DVB-T USB 2.0 sticks based on AF9035/AF9033. Currently supported devices:
> - Terratec T5 Ver.2 (also known as T6), Tuner FC0012
> - Avermedia Volar HD Nano (A867R), Tuner MxL5007t
> 
> Ver 1.02 of the driver includes the following changes compared to the initial version:
> 
> - significantly reduced number of mutex calls (only remaining protection in low-level af903x_send_cmd)
>   this change made some multiply defined function unnecessary (_internal functions and non _internal functions)
>   maybe this reduction was a bit too agressive, but I didn't get any problems in several days testing 
> - reduced number of iterations in loop for lock detection (should improve response)
> - correct errors in initial contribution and add proper entries in dvb-usb-ids.h (thanks to Gianluca Gennari)
> - removed unnecessary (loading of rc key table) and commented out code
> - minor cleanup (e.g. af903x_fe_is_locked)
> 

Hi Hans,
I just tested the new version of the driver on my a867 stick (single
mxl5007 tuner), on Ubuntu 11.10 with a vanilla 3.2.9 kernel and the
latest media_build tree installed.

I can confirm the two main issues I found on the previous version are
completely solved.
In fact, Kaffeine is much more responsive now, and I can also open the
window with the signal strength/quality bars without any sluggishness.
I also unplugged the device from the USB port under several different
conditions (watching a channel, doing a channel scan and so on) without
any kernel crash.

I tested several channels (UHF, VHF, QAM64, QAM16, QPSK, 8MHz, 7MHz,...)
with no problem: the reception was stable in all configurations. Zapping
is also much faster with this version. I will run longer tests in the
coming days.

The only minor issues that I could find are related to channel scanning.
A full scan with Kaffeine takes much longer than with other sticks (most
of the time is spent on empty frequencies).
Despite the long wait, some frequency is not locked (for example, the
very first VHF frequency, channel 5, is missed 100% of the times).
This problem seem to disappear disabling the PID filter (but I need
further testing to draw any conclusion).
Also, during a full scan, Kaffeine becomes sluggish again.

In the end, the driver seem to work fine now, with only a few minor issues.

Thank you for your effort.

Regards,
Gianluca

  reply	other threads:[~2012-03-12 17:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 22:21 [PATCH 2/3] Basic AF9035/AF9033 driver Hans-Frieder Vogt
2012-03-11 15:23 ` [PATCH] AF903X driver update, v1.02 Hans-Frieder Vogt
2012-03-12 17:10   ` Gianluca Gennari [this message]
2012-03-12 20:01     ` Malcolm Priestley
2012-03-20  0:28 ` [PATCH 2/3] Basic AF9035/AF9033 driver Mauro Carvalho Chehab
2012-03-20 13:04   ` Michael Büsch
2012-03-20 16:27     ` Gianluca Gennari
2012-03-20 16:37       ` Michael Büsch
2012-03-20 16:49         ` Gianluca Gennari
2012-03-20 17:32           ` Michael Büsch
2012-03-20 21:44             ` Add fc0011 tuner support (was: [PATCH 2/3] Basic AF9035/AF9033 driver) Michael Büsch
2012-03-21  7:52       ` [PATCH 2/3] Basic AF9035/AF9033 driver Oliver Schinagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E2E19.4010208@gmail.com \
    --to=gennarone@gmail.com \
    --cc=hfvogt@gmx.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.