From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: create a common IOMEM definition
Date: Mon, 12 Mar 2012 13:33:28 -0500 [thread overview]
Message-ID: <4F5E4178.50801@gmail.com> (raw)
In-Reply-To: <201203112134.45302.arnd@arndb.de>
On 03/11/2012 04:34 PM, Arnd Bergmann wrote:
> On Sunday 11 March 2012, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Several platforms create IOMEM defines for casting to 'void __iomem *',
>> and other platforms are incorrectly using __io() macro for the same
>> purpose. This creates a common definition and removes all the platform
>> specific versions. Rather than try to make linux/io.h and asm/io.h
>> assembly safe, the assembly version of IOMEM is moved into
>> asm/assembler.h.
>
> Looks good to me, in order to fix the problem at hand. I'm not sure
> about spreading the IOMEM() macro further, that is largely a separate
> problem and only a question of style, not of correctness as with __io().
Got a better suggestion? I didn't think adding IOMEM to 5 more platforms
or inventing something different was the right path. Hopefully this is a
shrinking problem as things move to DT.
Rob
> Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2012-03-12 18:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 21:08 [PATCH 0/4] mach/io.h cleanup fixes Rob Herring
2012-03-11 21:08 ` [PATCH 1/4] ARM: fix ioremap/iounmap for !CONFIG_MMU Rob Herring
2012-03-11 21:08 ` [PATCH 2/4] ARM: iop13xx: fix missing declaration of iop13xx_init_early Rob Herring
2012-03-11 21:08 ` [PATCH 3/4] ARM: create a common IOMEM definition Rob Herring
2012-03-11 21:34 ` Arnd Bergmann
2012-03-12 18:33 ` Rob Herring [this message]
2012-03-12 21:15 ` Arnd Bergmann
2012-03-12 4:23 ` Viresh Kumar
2012-03-12 18:42 ` Paul Walmsley
2012-03-13 8:51 ` Linus Walleij
2012-03-13 16:32 ` H Hartley Sweeten
2012-03-13 17:21 ` Tony Lindgren
2012-03-13 21:40 ` David Brown
2012-03-14 3:24 ` Olof Johansson
2012-03-14 7:11 ` Haojian Zhuang
2012-03-11 21:08 ` [PATCH 4/4] ARM: __io abuse cleanup Rob Herring
2012-03-11 21:08 ` Rob Herring
2012-03-11 21:35 ` Arnd Bergmann
2012-03-11 21:35 ` Arnd Bergmann
2012-03-12 19:42 ` Anton Vorontsov
2012-03-12 19:42 ` Anton Vorontsov
2012-03-13 8:56 ` Linus Walleij
2012-03-13 8:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E4178.50801@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.