From: Alex Elder <elder@dreamhost.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 2/5] libceph: only call kernel_sendpage() via helper
Date: Mon, 12 Mar 2012 17:40:16 -0500 [thread overview]
Message-ID: <4F5E7B50.6040509@dreamhost.com> (raw)
In-Reply-To: <4F5E79C6.6040301@dreamhost.com>
Make ceph_tcp_sendpage() be the only place kernel_sendpage() is
used, by using this helper in write_partial_msg_pages().
Signed-off-by: Alex Elder <elder@dreamhost.com>
---
net/ceph/messenger.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 9207a8c..adca1e6 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -904,17 +904,13 @@ static int write_partial_msg_pages(struct
ceph_connection *con)
con->out_msg->footer.data_crc = cpu_to_le32(crc);
con->out_msg_pos.did_page_crc = true;
}
- ret = kernel_sendpage(con->sock, page,
+ ret = ceph_tcp_sendpage(con->sock, page,
con->out_msg_pos.page_pos + page_shift,
- len,
- MSG_DONTWAIT | MSG_NOSIGNAL |
- MSG_MORE);
+ len, 1);
if (do_datacrc && kaddr != zero_page_address)
kunmap(page);
- if (ret == -EAGAIN)
- ret = 0;
if (ret <= 0)
goto out;
--
1.7.5.4
next prev parent reply other threads:[~2012-03-12 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 22:33 [PATCH 0/5] libceph: page mapping in the messenger Alex Elder
2012-03-12 22:40 ` [PATCH 1/5] libceph: use kernel_sendpage() for sending zeroes Alex Elder
2012-03-12 22:40 ` Alex Elder [this message]
2012-03-12 22:40 ` [PATCH 3/5] libceph: get rid of zero_page_address Alex Elder
2012-03-12 22:40 ` [PATCH 4/5] libceph: rename "page_shift" variable to something sensible Alex Elder
2012-03-12 22:40 ` [PATCH 5/5] libceph: isolate kmap() call in write_partial_msg_pages() Alex Elder
2012-03-13 5:31 ` [PATCH 0/5] libceph: page mapping in the messenger Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E7B50.6040509@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.