All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH 1/5] Add generic debug option
Date: Tue, 13 Mar 2012 10:58:40 +0800	[thread overview]
Message-ID: <4F5EB7E0.8040701@gmail.com> (raw)
In-Reply-To: <20120313002116.GB24671@verge.net.au>

On 03/13/2012 08:21 AM, Simon Horman wrote:
> On Thu, Mar 08, 2012 at 02:39:38PM +0800, Cong Wang wrote:
>> Currently the debugging code is under #ifdef DEBUG, which
>> means when we want to debug, we have to re-compile the source
>> code with -DDEBUG. This is not convenient, we want to have
>> a generic --debug option so that we can enable debugging code
>> without re-compiling.
>>
>> This patch moves the arch-specific --debug to generic place
>> and moves code under #ifdef DEBUG to --debug on x86.
>>
>> BTW, the size of kexec binary increases very little after this patch.
>
> Hi Cong,
>
> In general I am happy with making kexec easier to use.  However, it would
> be nice not to make kexec-tools even bigger than it already is. Its size
> already seems to be an issue for some people on ARM at least.  Do you
> have some feeling for the change in binary size on architectures other than
> i386?
>

Hi,

I only tested the patches on x86 and ppc.

Sorry I don't have a chance to test it on ARM, on ARM it just adds a 
small function dump_memory_ranges(), if this would be a problem, feel 
free to drop patch 3/5. :)

Thanks.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-03-13  2:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  6:39 [PATCH 1/5] Add generic debug option Cong Wang
2012-03-08  6:39 ` [PATCH 2/5] ppc: move DEBUG code to --debug Cong Wang
2012-03-15  6:38   ` Simon Horman
2012-03-15  6:38     ` Simon Horman
2012-03-08  6:39 ` [PATCH 3/5] arm: " Cong Wang
2012-03-08  6:39 ` [PATCH 4/5] mips: " Cong Wang
2012-03-08  6:39 ` [PATCH 5/5] sh: " Cong Wang
2012-03-13  0:21 ` [PATCH 1/5] Add generic debug option Simon Horman
2012-03-13  2:58   ` Cong Wang [this message]
2012-03-15  6:48     ` Simon Horman
2012-03-20 13:29       ` Cong Wang
2012-04-06  2:22         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5EB7E0.8040701@gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.