From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1S7OVb-0001bg-DV
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:59:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1S7OVU-0003Um-OM
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:59:10 -0400
Received: from [222.73.24.84] (port=22012 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1S7OVU-0003Px-Cw
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:59:04 -0400
Message-ID: <4F5F141F.8080202@cn.fujitsu.com>
Date: Tue, 13 Mar 2012 17:32:15 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
MIME-Version: 1.0
References: <1329347774-23262-1-git-send-email-imammedo@redhat.com>	<1329347774-23262-3-git-send-email-imammedo@redhat.com>	<4F3CF010.1040607@siemens.com>
	<4F3CFBBB.5020600@codemonkey.ws>
In-Reply-To: <4F3CFBBB.5020600@codemonkey.ws>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "gleb@redhat.com" <gleb@redhat.com>, Igor Mammedov <imammedo@redhat.com>

On 02/16/2012 08:51 PM, Anthony Liguori wrote:
> On 02/16/2012 06:01 AM, Jan Kiszka wrote:
>> On 2012-02-16 00:16, Igor Mammedov wrote:
>>> +static ICCBusDeviceInfo cpu_device_info = {
>>> +    .qdev.name = "cpu-pc",
>>> +    .qdev.size = sizeof(CPUPC),
>>> +    .qdev.reset = cpu_device_reset,
>>> +    .init = cpu_device_init,
>>> +    .qdev.props = (Property[]) {
>>> +        DEFINE_PROP_STRING("model", CPUPC, model),
>>
>> And how do you pass in feature flags? Or the core layout? Basically both
>> -cpu and -smp need to be expressible via multiple "-device cpu-x86,xxx"
>> (not "pc") commands.
> 
> The approach that I'd recommend is:
> 
> 1) convert CPU_COMMON_STATE to a structure named CPUCommonState, query/replace all references to members of CPU_COMMON_STATE appropriately.
> 

Hi, All

I just tried this for several days, it will result a huge patch,
it is hard for human, any suggestion?
(I used Semantic patches script: http://coccinelle.lip6.fr/, it is still hard,
it still leaves huge part which needs manual conversion/fix)

I will take part in implementing cpu-hotplug future for qemu,
Could you give me some tips/suggestions? What approach should I take?
The main work of my "taking part in" is assisting for this community,
So you can assign some works/steps to me.

Thanks,
Lai