Re: [PATCH] IIO: trigger: Add hrtimer trigger

[Lars-Peter Clausen <lars@metafoo.de>]

On 03/13/2012 02:18 PM, Lars-Peter Clausen wrote:
>[...]
> + static int __devinit iio_trig_hrtimer_probe(struct platform_device *pdev)
> +{
> [...]
> +
> +err_put_trigger:
> +	iio_put_trigger(trig);

Looking a bit closer a how iio triggers are managed I think I need to call
iio_free_trigger here instead of iio_put_trigger.

> +
> +	return ret;
> +}
> +
> +static int __devexit iio_trig_hrtimer_remove(struct platform_device *pdev)
> +{
> +	struct iio_hrtimer_trig_info *trig_info = platform_get_drvdata(pdev);
> +	struct iio_trigger *trig = trig_info->trigger;
> +
> +	hrtimer_cancel(&trig_info->timer);
> +	iio_trigger_unregister(trig);
> +

And I think here a iio_free_trigger is missing as well.
But it looks as if the existing trigger driver suffer from similar issues.

> +	return 0;
> +}
> +