All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6: Read silicon revision from register
Date: Tue, 13 Mar 2012 15:37:45 +0100	[thread overview]
Message-ID: <4F5F5BB9.2090104@de.bosch.com> (raw)
In-Reply-To: <1331648310-13064-1-git-send-email-fabio.estevam@freescale.com>

On 13.03.2012 15:18, Fabio Estevam wrote:
> Instead of hardcoding the mx6 silicon revision, read it from the proper register.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Fix typo on Subject
>  arch/arm/cpu/armv7/mx6/soc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c
> index 2ac74b5..639bf30 100644
> --- a/arch/arm/cpu/armv7/mx6/soc.c
> +++ b/arch/arm/cpu/armv7/mx6/soc.c
> @@ -32,7 +32,8 @@
>  
>  u32 get_cpu_rev(void)
>  {
> -	int system_rev = 0x61000 | CHIP_REV_1_0;
> +	int reg = readl(ANATOP_BASE_ADDR + 0x260) & 0xFF;

Can we get a register overlay instead of the 'ANATOP_BASE_ADDR + 0x260'? 
Like in the rest of the file, e.g.

readl(&fuse->mac_addr_high);
writel(0x00000000, &aips1->opacr0);

Best regards

Dirk

  reply	other threads:[~2012-03-13 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 14:18 [U-Boot] [PATCH v2] mx6: Read silicon revision from register Fabio Estevam
2012-03-13 14:37 ` Dirk Behme [this message]
2012-03-13 15:40 ` Eric Nelson
2012-03-13 15:49   ` Stefano Babic
2012-03-13 18:01     ` Eric Nelson
2012-03-13 17:04   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5F5BB9.2090104@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.