Re: [PATCH 0/3][V2] Hob Notebook Implementation

[Joshua Lock <josh@linux.intel.com>]

On 12/03/12 06:23, Shane Wang wrote:
> This patchset is to implement Hob self-defined notebook, and use it in the build details page.

I have raised some concerns with the implementation of this series on 
each of the patches. It may seem nit-picky but we really do need to 
start paying attention to the details at this point and polishing the 
functionality and work-flow of the new Hob.

I'm torn on the series. As it stands we see errors each time we use Hob 
in master as the standard Gtk notebook doesn't support some of the API 
in the Hob notebook that is being called - errors look bad.

However this series has some poor coding style and doesn't match the 
visual design - these also look bad, though arguably less so.

I don't mind whether we merge this and iterate on the implementation or 
hold on merging until we fix the implementation but I feel we need to 
address the issues.

What are others thoughts?

Joshua
-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre