From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 10/11] hugetlb/hugeshmget03: fix broken testcase
Date: Wed, 14 Mar 2012 09:58:14 +0800 [thread overview]
Message-ID: <4F5FFB36.60609@cn.fujitsu.com> (raw)
In-Reply-To: <1331614605-30347-11-git-send-email-caspar@casparzhang.com>
On 03/13/2012 12:56 PM, Caspar Zhang wrote:
>
> hugeshmget03 often returns ENOMEM, so that causes test fails. This patch
> fixes the problem by making the following changes:
>
> 1) reduce shm_size to minimum (1 hugepage);
> 2) reduce shmmni to 1/2 * nr_hugepages.
>
> so that when all shmids taken, memory allocated ~=
>
> 1/2 * nr_hugepages * hugepagesize < free memory
>
> Which means there will be no ENOMEM occurs, but ENOSPC as expected.
Hi Caspar:
IMO, this looks good and test OK . So
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> Signed-off-by: Caspar Zhang <caspar@casparzhang.com>
> ---
> .../kernel/mem/hugetlb/hugeshmget/hugeshmget03.c | 14 ++++++++++++--
> 1 files changed, 12 insertions(+), 2 deletions(-)
>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-03-14 1:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 4:56 [LTP] [PATCH 00/11] hugetlb multiple fixes Caspar Zhang
2012-03-13 4:56 ` [LTP] [PATCH 01/11] hugetlb/hugeshmat: cleanup codes Caspar Zhang
2012-03-13 6:17 ` Wanlong Gao
2012-03-13 4:56 ` [LTP] [PATCH 02/11] hugetlb/hugeshmat: set nr_hugepages in tests Caspar Zhang
2012-03-13 6:16 ` Wanlong Gao
2012-03-13 4:56 ` [LTP] [PATCH 03/11] hugetlb/hugeshmctl: cleanup codes Caspar Zhang
2012-03-13 4:56 ` [LTP] [PATCH 04/11] hugetlb/hugeshmctl: set nr_hugepages in tests Caspar Zhang
2012-03-13 6:23 ` Wanlong Gao
2012-03-13 4:56 ` [LTP] [PATCH 05/11] hugetlb/hugeshmdt: cleanup codes Caspar Zhang
2012-03-13 4:56 ` [LTP] [PATCH 06/11] hugetlb/hugeshmdt: set nr_hugepages in tests Caspar Zhang
2012-03-13 6:24 ` Wanlong Gao
2012-03-13 4:56 ` [LTP] [PATCH 07/11] hugetlb/hugeshmget: cleanup codes Caspar Zhang
2012-03-13 4:56 ` [LTP] [PATCH 08/11] hugetlb/hugeshmget: set nr_hugepages in tests Caspar Zhang
2012-03-13 6:25 ` Wanlong Gao
2012-03-13 4:56 ` [LTP] [PATCH 09/11] hugetlb/lib: cleanup codes Caspar Zhang
2012-03-13 4:56 ` [LTP] [PATCH 10/11] hugetlb/hugeshmget03: fix broken testcase Caspar Zhang
2012-03-13 12:44 ` Caspar Zhang
2012-03-14 1:58 ` Wanlong Gao [this message]
2012-03-13 4:56 ` [LTP] [PATCH 11/11] libltp: remove system_specific_hugepages_info Caspar Zhang
2012-03-13 6:28 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5FFB36.60609@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.