All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaclav Mocek <vmocek@gmail.com>
To: jlee@novell.com
Cc: mjg@redhat.com, platform-driver-x86@vger.kernel.org
Subject: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205
Date: Wed, 14 Mar 2012 03:01:49 +0000	[thread overview]
Message-ID: <4F600A1D.5060002@gmail.com> (raw)

Hi all,

I am an unhappy owner of Lenovo Ideapad S205 and the drivers in the 
current development kernel (2f1c2b8) soft-blocks its Wi-Fi. S205 loads 
two kernel modules - ideapad-laptop.c and acer-wmi.c. The rfkill is 
controlled by acer-wmi.c and there is already a support for S205:

     {
         .callback = dmi_matched,
         .ident = "Lenovo Ideapad S205",
         .matches = {
             DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
             DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
         },
         .driver_data = &quirk_lenovo_ideapad_s205,
     },

Unfortunately, my netbook has a different DMI_PRODUCT_NAME - "Brazos" 
instead of "10382LG" and there are at least eighteen possibilities [1]. 
I spent some time Googling, comparing Smolt profiles, reading S205 
Hardware Maintenance Manual [2]  and analysing the BIOS updates. It 
seems, that all S205 are based on AMD platform called "Inagua" (E300, 
E350, E450), use two types of Wi-Fi cards (RaLink RT3090 and AR9285), 
various combination of SO DIMMs (2 x 1GB, 1 x 2GB, 2 x 2GB), different 
sizes of hardrives and different keyboard layouts; so overall there are 
pretty much the same.

There is a rare netbook called Lenovo Ideapad S205s ("s" at the end), 
but this one is based on Intel's processors [3].

My proposal is very simple:

     {
          .callback = dmi_matched,
          .ident = "Lenovo Ideapad S205",
          .matches = {
              DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-            DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
+            DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad S205"),
          },
          .driver_data = &quirk_lenovo_ideapad_s205,
      },

It works. We are not able to test all product names and if the checking 
of DMI_PRODUCT_NAME is really required, it should be done in an 
additional step. The current situation is pretty bad - problems with 
UEFI booting (the only possibility)[4], impossibility to switch the 
power off, failing brightness control - and without a functional network 
connection for a start, it is better to throw it out of the window.

[1] 
http://smolt.fedoraproject.org/reports/view_profiles?profile=Ideapad+S205&search=Submit+Query
[2] http://www.manualowl.com/m/Lenovo/IdeaPad-S205/Manual/192357
[3] http://www.manualowl.com/m/Lenovo/IdeaPad-S205s/Manual/227621
[4] 
http://fedoraproject.org/wiki/Common_F16_bugs#UEFI_install_to_Lenovo_Ideapad_S205_fails_to_boot


Best Regards

Vaclav Mocek

             reply	other threads:[~2012-03-14  3:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14  3:01 Vaclav Mocek [this message]
2012-03-14  6:16 ` drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205 Ike Panhc
2012-03-14 21:49   ` Vaclav Mocek
2012-03-15 23:09   ` Vaclav Mocek
2012-03-16  3:46     ` Ike Panhc
2012-03-16  3:53       ` Ike Panhc
2012-03-16  4:34 ` joeyli
2012-03-20  0:45   ` Vaclav Mocek
2012-03-20  2:05     ` joeyli
2012-03-20  3:03       ` Ike Panhc
2012-03-20  3:22         ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F600A1D.5060002@gmail.com \
    --to=vmocek@gmail.com \
    --cc=jlee@novell.com \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.