From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250 Date: Tue, 13 Mar 2012 23:32:14 -0700 Message-ID: <4F603B6E.7000103@samsung.com> References: <1331652643-12626-1-git-send-email-kgene.kim@samsung.com> <1331652643-12626-8-git-send-email-kgene.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:55860 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030348Ab2CNGcR (ORCPT ); Wed, 14 Mar 2012 02:32:17 -0400 Received: by ghrr11 with SMTP id r11so1446564ghr.19 for ; Tue, 13 Mar 2012 23:32:16 -0700 (PDT) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Thomas Abraham Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, arnd@arndb.de, olof@lixom.net On 03/13/12 22:27, Thomas Abraham wrote: > On 13 March 2012 21:00, Kukjin Kim wrote: >> ARM: EXYNOS: irqs.h for exynos4 and exynos5 - WIP >> This patch adds the interrupt definitions for EXYNOS5250 at >> file. Basically, now it is needed for EXYNOS5250 >> interrupt and will be updated for single zImage next time. >> >> Signed-off-by: Kukjin Kim >> --- >> arch/arm/mach-exynos/common.c | 97 ++++-- >> arch/arm/mach-exynos/dev-ahci.c | 4 +- >> arch/arm/mach-exynos/dev-audio.c | 4 +- >> arch/arm/mach-exynos/include/mach/irqs.h | 580 ++++++++++++++++++++++-------- >> arch/arm/mach-exynos/mct.c | 23 +- >> arch/arm/plat-s5p/irq-pm.c | 25 +- >> arch/arm/plat-samsung/irq-vic-timer.c | 16 + >> 7 files changed, 548 insertions(+), 201 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c >> index 7fdb139..0b53018 100644 >> --- a/arch/arm/mach-exynos/common.c > > > [...] > >> for (irq = 0 ; irq<= 15 ; irq++) { >> eint0_15_data[irq] = IRQ_EINT(irq); >> >> - irq_set_handler_data(exynos4_get_irq_nr(irq), >> -&eint0_15_data[irq]); >> - irq_set_chained_handler(exynos4_get_irq_nr(irq), >> + if (soc_is_exynos5250()) { >> + irq_set_handler_data(exynos4_eint0_15_src_int[irq], >> +&eint0_15_data[irq]); >> + irq_set_chained_handler(exynos4_eint0_15_src_int[irq], >> + exynos4_irq_eint0_15); >> + } else { >> + irq_set_handler_data(exynos5_eint0_15_src_int[irq], >> +&eint0_15_data[irq]); >> + irq_set_chained_handler(exynos5_eint0_15_src_int[irq], >> exynos4_irq_eint0_15); >> + } >> } > > The external interrupt numbers for Exynos4 and Exynos5 have been > swapped. This needs to be fixed. > Oops again :-( let me fix it. Thanks, Thomas. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 13 Mar 2012 23:32:14 -0700 Subject: [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250 In-Reply-To: References: <1331652643-12626-1-git-send-email-kgene.kim@samsung.com> <1331652643-12626-8-git-send-email-kgene.kim@samsung.com> Message-ID: <4F603B6E.7000103@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/13/12 22:27, Thomas Abraham wrote: > On 13 March 2012 21:00, Kukjin Kim wrote: >> ARM: EXYNOS: irqs.h for exynos4 and exynos5 - WIP >> This patch adds the interrupt definitions for EXYNOS5250 at >> file. Basically, now it is needed for EXYNOS5250 >> interrupt and will be updated for single zImage next time. >> >> Signed-off-by: Kukjin Kim >> --- >> arch/arm/mach-exynos/common.c | 97 ++++-- >> arch/arm/mach-exynos/dev-ahci.c | 4 +- >> arch/arm/mach-exynos/dev-audio.c | 4 +- >> arch/arm/mach-exynos/include/mach/irqs.h | 580 ++++++++++++++++++++++-------- >> arch/arm/mach-exynos/mct.c | 23 +- >> arch/arm/plat-s5p/irq-pm.c | 25 +- >> arch/arm/plat-samsung/irq-vic-timer.c | 16 + >> 7 files changed, 548 insertions(+), 201 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c >> index 7fdb139..0b53018 100644 >> --- a/arch/arm/mach-exynos/common.c > > > [...] > >> for (irq = 0 ; irq<= 15 ; irq++) { >> eint0_15_data[irq] = IRQ_EINT(irq); >> >> - irq_set_handler_data(exynos4_get_irq_nr(irq), >> -&eint0_15_data[irq]); >> - irq_set_chained_handler(exynos4_get_irq_nr(irq), >> + if (soc_is_exynos5250()) { >> + irq_set_handler_data(exynos4_eint0_15_src_int[irq], >> +&eint0_15_data[irq]); >> + irq_set_chained_handler(exynos4_eint0_15_src_int[irq], >> + exynos4_irq_eint0_15); >> + } else { >> + irq_set_handler_data(exynos5_eint0_15_src_int[irq], >> +&eint0_15_data[irq]); >> + irq_set_chained_handler(exynos5_eint0_15_src_int[irq], >> exynos4_irq_eint0_15); >> + } >> } > > The external interrupt numbers for Exynos4 and Exynos5 have been > swapped. This needs to be fixed. > Oops again :-( let me fix it. Thanks, Thomas. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.