From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250 Date: Tue, 13 Mar 2012 23:43:57 -0700 Message-ID: <4F603E2D.1050007@samsung.com> References: <1331652643-12626-1-git-send-email-kgene.kim@samsung.com> <1331652643-12626-13-git-send-email-kgene.kim@samsung.com> <20120314035655.GB2531@quad.lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:63088 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884Ab2CNGn7 (ORCPT ); Wed, 14 Mar 2012 02:43:59 -0400 Received: by yenl12 with SMTP id l12so1445528yen.19 for ; Tue, 13 Mar 2012 23:43:59 -0700 (PDT) In-Reply-To: <20120314035655.GB2531@quad.lixom.net> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Olof Johansson Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, arnd@arndb.de, Thomas Abraham , Grant Likely On 03/13/12 20:56, Olof Johansson wrote: > On Tue, Mar 13, 2012 at 08:30:43AM -0700, Kukjin Kim wrote: >> This patch adds initial dts file for EXYNOS5250 SoC. This dts >> file is including the SoC specific devices and properties. And >> adds the dts file for SMDK5250 board which uses the EXYNOS5250 >> dts file. Its board specific properites will be added later. >> >> Cc: Thomas Abraham >> Cc: Grant Likely >> Signed-off-by: Kukjin Kim >> --- >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 26 ++ >> arch/arm/boot/dts/exynos5250.dtsi | 413 +++++++++++++++++++++++++++++ >> 2 files changed, 439 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/boot/dts/exynos5250-smdk5250.dts >> create mode 100644 arch/arm/boot/dts/exynos5250.dtsi >> >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> new file mode 100644 >> index 0000000..491539a >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts [...] >> + chosen { >> + bootargs = "root=/dev/ram0 rw ramdisk=8192 rootfstype=squashfs initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc"; > > Having these specific bootargs in the include file rarely makes sense, it's > better to have firmware update from the settings in firmware and just have a very > simple fallback here. > > In particular initrd is quite custom to hardcode like that. > Yes, the bootargs is no mandatory in dts file and u-boot bootargs can be set. OK, we can simplify it here like following. bootargs = "root=/dev/ram0 rw ramdisk=8192 console=ttySAC1,115200" [...] >> + watchdog@101D0000 { > > lowercase hex here and elsewhere in these files, please. > OK, I see. > Also, technically no need to specify a unit address (@) in the device node > name unless you need it to tell more than one entry apart, but it's become > customary to always add them on ARM for some reason. > OK, just to be consistent in writing device nodes, prefer to add address to the names for all device nodes. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 13 Mar 2012 23:43:57 -0700 Subject: [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250 In-Reply-To: <20120314035655.GB2531@quad.lixom.net> References: <1331652643-12626-1-git-send-email-kgene.kim@samsung.com> <1331652643-12626-13-git-send-email-kgene.kim@samsung.com> <20120314035655.GB2531@quad.lixom.net> Message-ID: <4F603E2D.1050007@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/13/12 20:56, Olof Johansson wrote: > On Tue, Mar 13, 2012 at 08:30:43AM -0700, Kukjin Kim wrote: >> This patch adds initial dts file for EXYNOS5250 SoC. This dts >> file is including the SoC specific devices and properties. And >> adds the dts file for SMDK5250 board which uses the EXYNOS5250 >> dts file. Its board specific properites will be added later. >> >> Cc: Thomas Abraham >> Cc: Grant Likely >> Signed-off-by: Kukjin Kim >> --- >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 26 ++ >> arch/arm/boot/dts/exynos5250.dtsi | 413 +++++++++++++++++++++++++++++ >> 2 files changed, 439 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/boot/dts/exynos5250-smdk5250.dts >> create mode 100644 arch/arm/boot/dts/exynos5250.dtsi >> >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> new file mode 100644 >> index 0000000..491539a >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts [...] >> + chosen { >> + bootargs = "root=/dev/ram0 rw ramdisk=8192 rootfstype=squashfs initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc"; > > Having these specific bootargs in the include file rarely makes sense, it's > better to have firmware update from the settings in firmware and just have a very > simple fallback here. > > In particular initrd is quite custom to hardcode like that. > Yes, the bootargs is no mandatory in dts file and u-boot bootargs can be set. OK, we can simplify it here like following. bootargs = "root=/dev/ram0 rw ramdisk=8192 console=ttySAC1,115200" [...] >> + watchdog at 101D0000 { > > lowercase hex here and elsewhere in these files, please. > OK, I see. > Also, technically no need to specify a unit address (@) in the device node > name unless you need it to tell more than one entry apart, but it's become > customary to always add them on ARM for some reason. > OK, just to be consistent in writing device nodes, prefer to add address to the names for all device nodes. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.