From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mitsyanko Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Wed, 14 Mar 2012 13:30:21 +0400 Message-ID: <4F60652D.20903@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F5DC546.6020203@samsung.com> Reply-To: i.mitsyanko@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7BIT Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Anthony Liguori , quintela@redhat.com, Developers qemu-devel , KVM devel mailing list , Dmitry Solodkiy To: Peter Maydell Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:14239 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242Ab2CNJaZ (ORCPT ); Wed, 14 Mar 2012 05:30:25 -0400 Received: from euspt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0M0V00M3TBQH9K@mailout1.w1.samsung.com> for kvm@vger.kernel.org; Wed, 14 Mar 2012 09:30:17 +0000 (GMT) Received: from [106.109.8.162] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M0V00K0IBQMX0@spt1.w1.samsung.com> for kvm@vger.kernel.org; Wed, 14 Mar 2012 09:30:23 +0000 (GMT) In-reply-to: <4F5DC546.6020203@samsung.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/12/2012 01:43 PM, Igor Mitsyanko wrote: > On 02/21/2012 07:33 PM, Peter Maydell wrote: >> >> Short summary: >> * switch wp groups to bitfield rather than int array >> * convert sd.c to use memory_region_init_ram() to allocate the wp groups >> (being careful to use memory_region_set_dirty() when we touch them) >> * we don't need variable-length fields for sd.c any more >> * rest of the vmstate conversion is straightforward >> > > After a conversion to bitfield wp_groups consumes 2048 bytes for 32 GB > SD image, do we really need live section for this? > I don't know how large is too large, but currently we have VMSTATE_UINT32_ARRAY(tx_status_fifo, lan9118_state, 512), VMSTATE_UINT32_ARRAY(rx_status_fifo, lan9118_state, 896), VMSTATE_UINT32_ARRAY(rx_fifo, lan9118_state, 3360), VMSTATE_INT32_ARRAY(rx_packet_size, lan9118_state, 1024), in hw/lan9118.c -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7kXR-0006DS-6z for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7kXK-0008A4-PL for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:30:32 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:47605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7kXK-00089x-JI for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:30:26 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=UTF-8; format=flowed Received: from euspt1 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M0V00MK9BQN9U60@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:30:23 +0000 (GMT) Received: from [106.109.8.162] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M0V00K0IBQMX0@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:30:23 +0000 (GMT) Date: Wed, 14 Mar 2012 13:30:21 +0400 From: Igor Mitsyanko In-reply-to: <4F5DC546.6020203@samsung.com> Message-id: <4F60652D.20903@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F5DC546.6020203@samsung.com> Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: KVM devel mailing list , quintela@redhat.com, Developers qemu-devel , Dmitry Solodkiy , Anthony Liguori , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 03/12/2012 01:43 PM, Igor Mitsyanko wrote: > On 02/21/2012 07:33 PM, Peter Maydell wrote: >> >> Short summary: >> * switch wp groups to bitfield rather than int array >> * convert sd.c to use memory_region_init_ram() to allocate the wp groups >> (being careful to use memory_region_set_dirty() when we touch them) >> * we don't need variable-length fields for sd.c any more >> * rest of the vmstate conversion is straightforward >> > > After a conversion to bitfield wp_groups consumes 2048 bytes for 32 GB > SD image, do we really need live section for this? > I don't know how large is too large, but currently we have VMSTATE_UINT32_ARRAY(tx_status_fifo, lan9118_state, 512), VMSTATE_UINT32_ARRAY(rx_status_fifo, lan9118_state, 896), VMSTATE_UINT32_ARRAY(rx_fifo, lan9118_state, 3360), VMSTATE_INT32_ARRAY(rx_packet_size, lan9118_state, 1024), in hw/lan9118.c -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com