From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Vadai Subject: Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC Date: Wed, 14 Mar 2012 12:42:43 +0200 Message-ID: <4F607623.9060904@mellanox.com> References: <1331659323-12904-1-git-send-email-amirv@mellanox.com> <1331659323-12904-5-git-send-email-amirv@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , , Roland Dreier , Oren Duer , Amir Vadai To: Dave Taht Return-path: Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:51376 "HELO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753746Ab2CNKmy (ORCPT ); Wed, 14 Mar 2012 06:42:54 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 03/13/2012 09:16 PM, Dave Taht wrote: > On Tue, Mar 13, 2012 at 10:21 AM, Amir Vadai wrote: >> From: Amir Vadai >> >> Set max rate-limit using sysfs file /sys/class/net//qos/ratelimit >> >> To set, enter a space separated list of values in units of 100Mbps. For >> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue: >> echo 50 100 100 100 100 100 100 100 100> /sys/class/net/eth2/qos/ratelimit > > At least in my world, rates go down as low as 128k. > > If this 'qos' sys value is intended to be a generic mechanism to be > used instead of (say) htb, > for more than one type of ethernet device.... I would argue that the > units need to be specified. > > Similarly what else is intended to live below the 'qos' subdir? This sys value is specific to our driver, and will be shown only on mlx4_en netdev's. We're open to suggestions to make it a generic sysfs entry. If it will really be generic, we will sure have well known units (for example KB) and we'll do the translation in our driver. Thanks, Amir