From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 7/8] arm: use bootargs for the command line
Date: Wed, 14 Mar 2012 11:26:41 +0000
Message-ID: <4F608071.7030200@citrix.com>
References: <1330448064-32267-1-git-send-email-david.vrabel@citrix.com>	
	<1330448064-32267-8-git-send-email-david.vrabel@citrix.com>
	<1331721974.23971.392.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1331721974.23971.392.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 14/03/12 10:46, Ian Campbell wrote:
> On Tue, 2012-02-28 at 16:54 +0000, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Use the /chosen node's bootargs parameter for the Xen command line.
>> Parse it early on before the serial console is setup.
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> 
> Looks good to me. Did you build/test the cmdline_parse change on x86 (or
> non-ARM) too?

I built it for x86, yes.  I also looked quite carefully at
cmdline_parse() -- it seems the missing const is an accidental ommision.

> Assuming that changes stands alone it might be useful to split it out
> and submit it to Keir separately.

Ok.

David