Re: [PATCH 1/6] scripts/bitbake: ensure user is in build directory

[Darren Hart <dvhart@linux.intel.com>]

On 03/13/2012 05:36 PM, Paul Eggleton wrote:
> If the user is in any directory other than $BUILDDIR when the bitbake
> wrapper script is run, then show an error an exit.
> 
> Fixes [YOCTO #2071].
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  scripts/bitbake |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/bitbake b/scripts/bitbake
> index dda3b26..45c8697 100755
> --- a/scripts/bitbake
> +++ b/scripts/bitbake
> @@ -47,6 +47,11 @@ float_test() {
>  # but earlier versions do not
>  float_test "$TARVERSION > 1.23" && needtar="0"
>  
> +if [ "`pwd`" != "$BUILDDIR" ] ; then
> +    echo "BitBake must be run from your build directory: $BUILDDIR"
> +    exit 1

Should this have some kind of prefix? "ERROR: " or something along those
lines for consistency with other output?

Otherwise, YAY! I've tripped over this frequently and keep doing the cd
dance after a short "What the heck" session. Such a simple fix to -
Thanks Paul!

> +fi
> +
>  buildpseudo="1"
>  if [ $needpseudo = "1" ] && [ -e "$BUILDDIR/pseudodone" ]; then
>      PSEUDOBINDIR=`cat $BUILDDIR/pseudodone`

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel