From: Chris Metcalf <cmetcalf@tilera.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: <torvalds@linux-foundation.org>,
Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<stable@kernel.org>
Subject: Re: [PATCH] tile: remove a non-existing header
Date: Wed, 14 Mar 2012 15:07:56 -0400 [thread overview]
Message-ID: <4F60EC8C.1040400@tilera.com> (raw)
In-Reply-To: <1331561930-14964-1-git-send-email-mchehab@redhat.com>
On 3/12/2012 10:18 AM, Mauro Carvalho Chehab wrote:
> Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
> with this fix. It fails at arch/tile/include/asm/atomic_64.h because
> atomic64_t is never defined, but it is used there and on other places.
I suspect you may be trying to use tilepro_defconfig with ARCH=tilegx.
It's only valid for ARCH=tilepro, just like tilegx_defconfig is only valid
for ARCH=tilegx. There's some #ifdefs that are supposed to catch this (in
asm-offsets.c) but it's coming too late. I'll move it so it's before all
the #includes so at least it will be the first error that you see!
> Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
> sub-archs, it is not included on tilegx_defconfig. It would make sense
> to add it there, in order to make easier for people to test/use the
> EDAC drivers.
Fixed now in Linus' tree.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2012-03-14 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 14:18 [PATCH] tile: remove a non-existing header Mauro Carvalho Chehab
2012-03-12 14:31 ` Chris Metcalf
2012-03-12 15:00 ` Mauro Carvalho Chehab
2012-03-12 15:04 ` Chris Metcalf
2012-03-12 18:18 ` Chris Metcalf
2012-03-13 13:28 ` Mauro Carvalho Chehab
2012-03-14 19:07 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60EC8C.1040400@tilera.com \
--to=cmetcalf@tilera.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.