From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img
Date: Wed, 14 Mar 2012 13:08:36 -0600 [thread overview]
Message-ID: <4F60ECB4.6050006@redhat.com> (raw)
In-Reply-To: <1331751444-30905-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On 03/14/2012 12:57 PM, Stefan Weil wrote:
> qemu-img requires first options, then file name, then size.
>
> GNU getopt also allows options at the end, but POSIX getopt
> doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX
> behaviour with GNU getopt, too.
That's a heavy sledgehammer, that has the potential to affect a lot of
other programs called alongside qemu-img. Simpler would be to just pass
-- in the command line at the point where you want to force qemu to
treat all further arguments without getopt reordering them, as in:
> # XXX(hch): have global image options?
> - $QEMU_IMG create -f $IMGFMT $TEST_IMG $extra_img_options | \
> + $QEMU_IMG create -f $IMGFMT $extra_img_options $TEST_IMG $image_size | \
$QEMU_IMG -- create -f $IMGFMT $extra_img_options $TEST_IMG $image_size
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-03-14 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 18:57 [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img Stefan Weil
2012-03-14 18:57 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Fix call syntax for qemu-io Stefan Weil
2012-03-14 19:08 ` Eric Blake [this message]
2012-03-14 20:48 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img Stefan Weil
2012-03-27 20:56 ` Stefan Weil
2012-03-28 10:32 ` Stefan Hajnoczi
2012-04-05 13:11 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60ECB4.6050006@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.