All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Michael Walle <michael@walle.cc>,
	qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH urgent] target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef
Date: Wed, 14 Mar 2012 19:51:56 -0500	[thread overview]
Message-ID: <4F613D2C.6070001@codemonkey.ws> (raw)
In-Reply-To: <1331770782-20105-1-git-send-email-afaerber@suse.de>

On 03/14/2012 07:19 PM, Andreas Färber wrote:
> Commit 9b9a970a23625de4ae6b7461906a9a0d98d3ca95
> (target-lm32/microblaze: Typedef struct CPU{MB,LM32}State)
> introduced necessary typedefs for cpu_mmu_index() and mmu.h
> respectively.
>
> On some GCC versions this leads to "error: redefinition of typedef".
>
> Drop the original typedef to hopefully fix the build.
>
> Signed-off-by: Andreas Färber<afaerber@suse.de>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   target-lm32/cpu.h       |    4 ++--
>   target-microblaze/cpu.h |    4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h
> index 0902a24..a7d9546 100644
> --- a/target-lm32/cpu.h
> +++ b/target-lm32/cpu.h
> @@ -149,7 +149,7 @@ enum {
>       LM32_FLAG_IGNORE_MSB = 1,
>   };
>
> -typedef struct CPULM32State {
> +struct CPULM32State {
>       /* general registers */
>       uint32_t regs[32];
>
> @@ -182,7 +182,7 @@ typedef struct CPULM32State {
>       uint8_t num_bps;
>       uint8_t num_wps;
>
> -} CPULM32State;
> +};
>
>
>   CPULM32State *cpu_lm32_init(const char *cpu_model);
> diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
> index 3b52421..33b23c2 100644
> --- a/target-microblaze/cpu.h
> +++ b/target-microblaze/cpu.h
> @@ -230,7 +230,7 @@ typedef struct CPUMBState CPUMBState;
>   #define STREAM_CONTROL   (1<<  3)
>   #define STREAM_NONBLOCK  (1<<  4)
>
> -typedef struct CPUMBState {
> +struct CPUMBState {
>       uint32_t debug;
>       uint32_t btaken;
>       uint32_t btarget;
> @@ -264,7 +264,7 @@ typedef struct CPUMBState {
>   #endif
>
>       CPU_COMMON
> -} CPUMBState;
> +};
>
>   CPUMBState *cpu_mb_init(const char *cpu_model);
>   int cpu_mb_exec(CPUMBState *s);

      reply	other threads:[~2012-03-15  0:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  0:19 [Qemu-devel] [PATCH urgent] target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef Andreas Färber
2012-03-15  0:51 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F613D2C.6070001@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=afaerber@suse.de \
    --cc=edgar.iglesias@gmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=michael@walle.cc \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.