All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung.kim@lge.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] help: Add 'help.follow-alias' config item
Date: Thu, 15 Mar 2012 15:29:04 +0900	[thread overview]
Message-ID: <4F618C30.2030407@lge.com> (raw)
In-Reply-To: <7v7gymmm9a.fsf@alter.siamese.dyndns.org>

2012-03-15 3:06 PM, Junio C Hamano wrote:
> Namhyung Kim<namhyung.kim@lge.com>  writes:
>
>> The 'help.follow-alias' config option is used to determine the
>> default value of '--follow-alias' option. To do this, move some
>> codes to honor the priority of command line options.
>
> How badly would this change break what 7c3baa9 (help -a: do not
> unnecessarily look for a repository, 2009-09-04) tried to fix?
>

Oops, I was completely unaware of the problem, sorry :(.


>> diff --git a/Documentation/git-help.txt b/Documentation/git-help.txt
>> index debf293..9725e9f 100644
>> --- a/Documentation/git-help.txt
>> +++ b/Documentation/git-help.txt
>> @@ -80,6 +80,14 @@ line option:
>>   * "info" corresponds to '-i|--info',
>>   * "web" or "html" correspond to '-w|--web'.
>>
>> +help.follow-alias
>
> Please be consistent with existing ones.  I think we spell multi-word
> variable names without hyphens.
>

Will fix if you're OK with this series.

Thanks,
Namhyung

  reply	other threads:[~2012-03-15  6:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  2:52 [PATCH 1/3] help: Fix help message for aliases Namhyung Kim
2012-03-15  2:52 ` [PATCH 2/3] help: Add '--follow-alias' option Namhyung Kim
2012-03-15  6:00   ` Junio C Hamano
2012-03-15  6:15     ` 김남형
2012-03-15  6:23       ` Junio C Hamano
2012-03-15  6:46         ` Namhyung Kim
2012-03-15  7:09           ` Junio C Hamano
2012-03-15  2:52 ` [PATCH 3/3] help: Add 'help.follow-alias' config item Namhyung Kim
2012-03-15  6:06   ` Junio C Hamano
2012-03-15  6:29     ` Namhyung Kim [this message]
2012-03-15  4:17 ` [PATCH 1/3] help: Fix help message for aliases Jeff King
2012-03-15  5:15   ` 김남형
2012-03-15 13:19     ` Jeff King
2012-03-15  5:23 ` Junio C Hamano
2012-03-15  5:48   ` 김남형
2012-03-15  6:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F618C30.2030407@lge.com \
    --to=namhyung.kim@lge.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.