From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net, Jeffrey Burke <jburke@redhat.com>
Subject: Re: [LTP] [PATCH] io_submit: uninitialized iocb may not return -EINVAL
Date: Thu, 15 Mar 2012 15:56:23 +0800 [thread overview]
Message-ID: <4F61A0A7.1030402@cn.fujitsu.com> (raw)
In-Reply-To: <dfd33bd8-1212-4dd8-b7a9-87ea6d05760c@zmail17.collab.prod.int.phx2.redhat.com>
Hi Jan,
>>> --- a/testcases/kernel/syscalls/io_submit/io_submit01.c
>>> +++ b/testcases/kernel/syscalls/io_submit/io_submit01.c
>>> @@ -126,7 +126,21 @@ int main(int argc, char *argv[])
>>> /* 1.3 - EINVAL: uninitialized iocb */
>>> iocbs[0] = &iocb;
>>> TEST(io_submit(ctx, 1, iocbs));
>>> - check_result(-EINVAL, TEST_RETURN);
>>> + switch(TEST_RETURN) {
>>> + case -EINVAL:
>>> + case -EBADF:
>>> + case -EFAULT:
>>> + case -EPERM:
>>
>>
>> I don't think io_submit(2) can return -EPERM.
>>
>> Do you think so?
>
> I was trying all sorts of random data and I remember seeing once "-1".
> I'm failing to reproduce it today, so I could be wrong. If I fail to find
> data that gives -EPERM, I'll remove it in v2.
I looked into the io_submit(2) code in kernel and didn't see any path can
return -EPERM, so I think you should confirm on it again.
Thanks,
Wanlong Gao
>
> Regards,
> Jan
>
>>
>> Thanks,
>> Wanlong Gao
>>
>
>
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-03-15 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 14:53 [LTP] [PATCH] io_submit: uninitialized iocb may not return -EINVAL Jan Stancek
2012-03-15 1:09 ` Wanlong Gao
2012-03-15 2:09 ` Wanlong Gao
2012-03-15 7:48 ` Jan Stancek
2012-03-15 7:56 ` Wanlong Gao [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-27 9:52 [LTP] crashme:fork12 test may kill other process that is not forked child 羅秉鈞
2012-06-29 7:45 ` Wanlong Gao
2012-10-09 6:08 ` [LTP] [PATCH] io_submit: uninitialized iocb may not return -EINVAL Nitin Yadav
2012-10-16 2:31 ` Wanlong Gao
2012-10-16 6:53 ` Jan Stancek
2012-10-16 10:11 ` chrubis
2012-07-05 13:03 Nitin Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61A0A7.1030402@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=jburke@redhat.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.