From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size
Date: Thu, 15 Mar 2012 11:55:15 +0200 [thread overview]
Message-ID: <4F61BC83.2010700@redhat.com> (raw)
In-Reply-To: <4F61008B.4070007@codemonkey.ws>
On 03/14/2012 10:33 PM, Anthony Liguori wrote:
> On 03/06/2012 09:50 AM, Avi Kivity wrote:
>> The kvmvapic code remaps a section of ROM as RAM to allow the guest to
>> maintain state there. It is careful to align the section size to a page
>> boundary, to avoid creating subpages, but neglects to do the same for
>> the start address. These leads to an assert later on when the memory
>> core tries to create a page which is half RAM and half ROM.
>>
>> Fix by aligning the start address to a page boundary.
>>
>> This can be triggered by running qemu-system-x86_64 -enable-kvm -vga
>> none.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>
> Tested-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Are you going to do a PULL request or do you want me to apply directly?
I forgot all about it, sorry.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-15 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 15:50 [Qemu-devel] [PATCH] kvmvapic: align start address as well as size Avi Kivity
2012-03-06 16:01 ` Jan Kiszka
2012-03-14 20:33 ` Anthony Liguori
2012-03-15 9:55 ` Avi Kivity [this message]
2012-03-15 13:16 ` Anthony Liguori
2012-03-14 21:18 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61BC83.2010700@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.