From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8822-0007ax-H0 for qemu-devel@nongnu.org; Thu, 15 Mar 2012 06:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S881v-0006hg-Ai for qemu-devel@nongnu.org; Thu, 15 Mar 2012 06:35:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40670 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S881v-0006hQ-5D for qemu-devel@nongnu.org; Thu, 15 Mar 2012 06:35:35 -0400 Message-ID: <4F61C5F4.7000206@suse.de> Date: Thu, 15 Mar 2012 11:35:32 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331796924-30669-1-git-send-email-i.mitsyanko@samsung.com> <1331796924-30669-2-git-send-email-i.mitsyanko@samsung.com> In-Reply-To: <1331796924-30669-2-git-send-email-i.mitsyanko@samsung.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com Am 15.03.2012 08:35, schrieb Igor Mitsyanko: > Create 9 exynos4210 i2c interfaces. >=20 > Signed-off-by: Igor Mitsyanko Reviewed-by: Andreas F=E4rber for the non-technical aspects. One remark below. > diff --git a/hw/exynos4210_i2c.c b/hw/exynos4210_i2c.c > new file mode 100644 > index 0000000..42f770d > --- /dev/null > +++ b/hw/exynos4210_i2c.c > +enum { > + idle, > + start_bit_received, > + sending_data, > + receiving_data > +}; Usually our enum values are uppercase, not sure if that's a rule. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg