From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S88WY-0007Tm-3k
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 07:07:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S88W7-0004DM-2y
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 07:07:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43108 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S88W6-0004DG-TX
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 07:06:47 -0400
Message-ID: <4F61CD42.9070801@suse.de>
Date: Thu, 15 Mar 2012 12:06:42 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331796924-30669-1-git-send-email-i.mitsyanko@samsung.com>
	<1331796924-30669-3-git-send-email-i.mitsyanko@samsung.com>
In-Reply-To: <1331796924-30669-3-git-send-email-i.mitsyanko@samsung.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com

Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
> Now that we have GPIO emulation for exynos4210 SoC we can use it to
> properly hook up IRQ line to lan9215 controller on SMDK board.
>=20
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>

The patches for .instance_size were applied now, so the TypeInfos look
okay, although a bit confusing at first. ;) Same for .class_size but
type_initialize() seems to handle that correctly.

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

All static TypeInfos could be made const for a v3.

Series looks plausible; Peter should take a second, closer look though.
Probably best to wait for more comments before resending minor fixes.

Thanks,

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg