From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 02/13] memcg: Kernel memory accounting infrastructure. Date: Thu, 15 Mar 2012 15:07:15 +0400 Message-ID: <4F61CD63.4090007@parallels.com> References: <1331325556-16447-1-git-send-email-ssouhlal@FreeBSD.org> <1331325556-16447-3-git-send-email-ssouhlal@FreeBSD.org> <4F5C5E54.2020408@parallels.com> <20120313152446.28b0d696.kamezawa.hiroyu@jp.fujitsu.com> <4F5F236A.1070609@parallels.com> <20120314091526.3c079693.kamezawa.hiroyu@jp.fujitsu.com> <4F608F25.3010700@parallels.com> <4F613C5B.8030304@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F613C5B.8030304-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: KAMEZAWA Hiroyuki Cc: Suleiman Souhlal , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org, yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, dan.magenheimer-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mgorman-l3A5Bk7waGM@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 03/15/2012 04:48 AM, KAMEZAWA Hiroyuki wrote: >>> - What happens when a new cgroup created ? >> > >> > mem_cgroup_create() is called =) >> > Heh, jokes apart, I don't really follow here. What exactly do you mean? >> > There shouldn't be anything extremely out of the ordinary. >> > > > Sorry, too short words. > > Assume a cgroup with > cgroup.memory.limit_in_bytes=1G > cgroup.memory.kmem.limit_in_bytes=400M > > When a child cgroup is created, what should be the default values. > 'unlimited' as current implementation ? > Hmm..maybe yes. I think so, yes. I see no reason to come up with any default values in memcg. Yes, your allocations can fail due to your parent limits. But since I never heard of any machine with 9223372036854775807 bytes of memory, that is true even for the root memcg =) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id 95FB96B0044 for ; Thu, 15 Mar 2012 07:08:53 -0400 (EDT) Message-ID: <4F61CD63.4090007@parallels.com> Date: Thu, 15 Mar 2012 15:07:15 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2 02/13] memcg: Kernel memory accounting infrastructure. References: <1331325556-16447-1-git-send-email-ssouhlal@FreeBSD.org> <1331325556-16447-3-git-send-email-ssouhlal@FreeBSD.org> <4F5C5E54.2020408@parallels.com> <20120313152446.28b0d696.kamezawa.hiroyu@jp.fujitsu.com> <4F5F236A.1070609@parallels.com> <20120314091526.3c079693.kamezawa.hiroyu@jp.fujitsu.com> <4F608F25.3010700@parallels.com> <4F613C5B.8030304@jp.fujitsu.com> In-Reply-To: <4F613C5B.8030304@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: Suleiman Souhlal , cgroups@vger.kernel.org, suleiman@google.com, penberg@kernel.org, cl@linux.com, yinghan@google.com, hughd@google.com, gthelen@google.com, peterz@infradead.org, dan.magenheimer@oracle.com, hannes@cmpxchg.org, mgorman@suse.de, James.Bottomley@HansenPartnership.com, linux-mm@kvack.org, devel@openvz.org, linux-kernel@vger.kernel.org On 03/15/2012 04:48 AM, KAMEZAWA Hiroyuki wrote: >>> - What happens when a new cgroup created ? >> > >> > mem_cgroup_create() is called =) >> > Heh, jokes apart, I don't really follow here. What exactly do you mean? >> > There shouldn't be anything extremely out of the ordinary. >> > > > Sorry, too short words. > > Assume a cgroup with > cgroup.memory.limit_in_bytes=1G > cgroup.memory.kmem.limit_in_bytes=400M > > When a child cgroup is created, what should be the default values. > 'unlimited' as current implementation ? > Hmm..maybe yes. I think so, yes. I see no reason to come up with any default values in memcg. Yes, your allocations can fail due to your parent limits. But since I never heard of any machine with 9223372036854775807 bytes of memory, that is true even for the root memcg =) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761120Ab2COLIy (ORCPT ); Thu, 15 Mar 2012 07:08:54 -0400 Received: from mx2.parallels.com ([64.131.90.16]:59393 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759297Ab2COLIw (ORCPT ); Thu, 15 Mar 2012 07:08:52 -0400 Message-ID: <4F61CD63.4090007@parallels.com> Date: Thu, 15 Mar 2012 15:07:15 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: Suleiman Souhlal , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 02/13] memcg: Kernel memory accounting infrastructure. References: <1331325556-16447-1-git-send-email-ssouhlal@FreeBSD.org> <1331325556-16447-3-git-send-email-ssouhlal@FreeBSD.org> <4F5C5E54.2020408@parallels.com> <20120313152446.28b0d696.kamezawa.hiroyu@jp.fujitsu.com> <4F5F236A.1070609@parallels.com> <20120314091526.3c079693.kamezawa.hiroyu@jp.fujitsu.com> <4F608F25.3010700@parallels.com> <4F613C5B.8030304@jp.fujitsu.com> In-Reply-To: <4F613C5B.8030304@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [188.255.67.70] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2012 04:48 AM, KAMEZAWA Hiroyuki wrote: >>> - What happens when a new cgroup created ? >> > >> > mem_cgroup_create() is called =) >> > Heh, jokes apart, I don't really follow here. What exactly do you mean? >> > There shouldn't be anything extremely out of the ordinary. >> > > > Sorry, too short words. > > Assume a cgroup with > cgroup.memory.limit_in_bytes=1G > cgroup.memory.kmem.limit_in_bytes=400M > > When a child cgroup is created, what should be the default values. > 'unlimited' as current implementation ? > Hmm..maybe yes. I think so, yes. I see no reason to come up with any default values in memcg. Yes, your allocations can fail due to your parent limits. But since I never heard of any machine with 9223372036854775807 bytes of memory, that is true even for the root memcg =)