From: "H. Peter Anvin" <hpa@zytor.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, matt.fleming@intel.com
Subject: Re: [PATCH] EFI: Only set regions uncacheable if they support it
Date: Thu, 15 Mar 2012 07:36:46 -0700 [thread overview]
Message-ID: <4F61FE7E.9060600@zytor.com> (raw)
In-Reply-To: <20120315143308.GA4382@srcf.ucam.org>
On 03/15/2012 07:33 AM, Matthew Garrett wrote:
>>
>> If we map it WB software can do speculative loads from that region which
>> would bring it into the cache. If we map it UC we might have to CLFLUSH...
>
> We've already mapped it at this point - we then go back and flag it UC
> if it's not writeback. The latter seems to be causing problems, I'm not
> sure we've seen any indication that the former is. And these regions are
> marked as runtime accessible, so per spec they do need to be mapped into
> address space...
>
In other words, it's totally f*cked. I guess at that point mapping it
WB and letting the BIOS-configured MTRRs deal with the caching
attributes is probably the right thing to do.
I would still really like to understand why we're seeing #MCs... that's
bothersome all by itself.
-hpa
next prev parent reply other threads:[~2012-03-15 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 13:56 [PATCH] EFI: Only set regions uncacheable if they support it Matthew Garrett
2012-03-15 14:00 ` H. Peter Anvin
2012-03-15 14:07 ` Matthew Garrett
2012-03-15 14:17 ` H. Peter Anvin
2012-03-15 14:24 ` Matthew Garrett
2012-03-15 14:28 ` H. Peter Anvin
2012-03-15 14:33 ` Matthew Garrett
2012-03-15 14:36 ` H. Peter Anvin [this message]
2012-03-15 14:42 ` Matthew Garrett
2012-03-15 14:47 ` H. Peter Anvin
2012-03-15 14:54 ` Matthew Garrett
2012-03-15 14:51 ` Alan Cox
2012-03-15 14:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61FE7E.9060600@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.