From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chase Douglas Subject: Re: Mixed "pen" and multitouch input devices Date: Thu, 15 Mar 2012 19:03:12 -0700 Message-ID: <4F629F60.7010600@gmail.com> References: <20120315155235.GA6783@stud.informatik.uni-erlangen.de> <20120315175635.GA23155@stud.informatik.uni-erlangen.de> <4F623511.3040907@gmail.com> <20120316015224.GA8230@stud.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:37431 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721Ab2CPCCr (ORCPT ); Thu, 15 Mar 2012 22:02:47 -0400 Received: by dajr28 with SMTP id r28so5382494daj.19 for ; Thu, 15 Mar 2012 19:02:46 -0700 (PDT) In-Reply-To: <20120316015224.GA8230@stud.informatik.uni-erlangen.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Thorsten Wissmann Cc: Chris Bagwell , Henrik Rydberg , linux-input@vger.kernel.org, =?ISO-8859-1?Q?Maximilian_Kr=FCger?= , i4passt@lists.informatik.uni-erlangen.de On 03/15/2012 06:52 PM, Thorsten Wissmann wrote: > On Thu, Mar 15, 2012 at 11:29:37AM -0700, Chase Douglas wrote: >> On 03/15/2012 10:56 AM, Thorsten Wissmann wrote: >>> On Thu, Mar 15, 2012 at 12:27:22PM -0500, Chris Bagwell wrote: >>>> If you want to work with other unmodified user land apps (perhaps >>>> xf86-input-evdev for touches) then its probably easiest to split pen >>>> and touch to separate input devices. drivers/input/tablet/wacom_wac.c >>>> shows some examples of that approach but that driver doesn't have to >>>> work to hard to split in to 2 input devices because the USB device >>>> already puts the events on separate USB interfaces. >>> >>> OK. We want the device to work with the xf86-input-evdev driver. So we >>> will split it into two devices. >> >> Or you could teach evdev to know how to handle mixed devices :). I think >> that's the "better" approach over all, but it's up to you. > > Thanks! We didn't thought about this. It turned out that the problem > isn't caused by the usage of both BTN_TOOL_PEN and BTN_TOOL_FINGER. > > It turned out xf86-input-evdev really discards all non-multitouch events > (especially ABS_X and ABS_Y) events in EvdevProcessAbsoluteMotionEvent() > in evdev.c, if the device is configured as a multitouch device. So there > is a quick fix (or only workaround?), which processes ABS_X and ABS_Y > events even if it is a multitouch device: > > diff --git a/src/evdev.c b/src/evdev.c > index d540b87..b857b83 100644 > --- a/src/evdev.c > +++ b/src/evdev.c > @@ -832,7 +832,7 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo, > struct input_event *ev) > if (ev->code >= ABS_MT_SLOT) { > EvdevProcessTouchEvent(pInfo, ev); > pEvdev->abs_queued = 1; > - } else if (!pEvdev->mt_mask) { > + } else if (!pEvdev->mt_mask || ev->code == ABS_X || ev->code == > ABS_Y) { > map = pEvdev->axis_map[ev->code]; > valuator_mask_set(pEvdev->vals, map, value); > pEvdev->abs_queued = 1; > > This patch already is submitted to the xorg bugtracker and can be found > at [1]. > > The only remaining question is: Does it break other drivers? > > Max and Thorsten > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=47382 Great! I haven't fully thought about it enough to give a reviewed-by, but it seems sane. I suggest sending the patch to xorg-devel@lists.x.org. That's where most patch reviews are handled. You will likely get faster results there. -- Chase