From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8Qxg-0001jV-E2
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:48:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8QxQ-0005UR-Pp
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:48:28 -0400
Received: from [222.73.24.84] (port=15031 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8QxQ-0005UJ-EN
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:48:12 -0400
Message-ID: <4F62E29E.7000904@cn.fujitsu.com>
Date: Fri, 16 Mar 2012 14:50:06 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4F5FFC63.3060300@cn.fujitsu.com>	<4F5FFDD6.2000300@cn.fujitsu.com>
	<20120316.104836.424250617.d.hatayama@jp.fujitsu.com>
In-Reply-To: <20120316.104836.424250617.d.hatayama@jp.fujitsu.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to
 write cpu status to core file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: jan.kiszka@siemens.com, anderson@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com, lcapitulino@redhat.com

At 03/16/2012 09:48 AM, HATAYAMA Daisuke Wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file
> Date: Wed, 14 Mar 2012 10:09:26 +0800
> 
>> +    memset(note, 0, note_size);
>> +    if (type == 0) {
>> +        note32 = note;
>> +        note32->n_namesz = cpu_to_le32(name_size);
>> +        note32->n_descsz = cpu_to_le32(descsz);
>> +        note32->n_type = 0;
>> +    } else {
>> +        note64 = note;
>> +        note64->n_namesz = cpu_to_le32(name_size);
>> +        note64->n_descsz = cpu_to_le32(descsz);
>> +        note64->n_type = 0;
>> +    }
> 
> Why not give new type for this note information an explicit name?
> Like NT_QEMUCPUSTATE? There might be another type in the future. This
> way there's also a merit that we can know all the existing notes
> relevant to qemu dump by looking at the names in a header file.

Hmm, how to add a new type? Does someont manage this?

Thanks
Wen Congyang

> 
> Thanks.
> HATAYAMA, Daisuke
> 
>