Re: [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping

[Wen Congyang <wency@cn.fujitsu.com>]

At 03/16/2012 11:52 AM, HATAYAMA Daisuke Wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [RFC][PATCH 05/14 v9] Add API to get memory mapping
> Date: Wed, 14 Mar 2012 10:07:48 +0800
> 
>>  }
>> +
>> +int qemu_get_guest_memory_mapping(MemoryMappingList *list)
>> +{
>> +    CPUState *env;
>> +    RAMBlock *block;
>> +    ram_addr_t offset, length;
>> +    int ret;
>> +    bool paging_mode;
>> +
>> +#if defined(CONFIG_HAVE_GET_MEMORY_MAPPING)
>> +    paging_mode = cpu_paging_enabled(first_cpu);
>> +    if (paging_mode) {
>> +        for (env = first_cpu; env != NULL; env = env->next_cpu) {
>> +            ret = cpu_get_memory_mapping(list, env);
>> +            if (ret < 0) {
>> +                return -1;
>> +            }
>> +        }
>> +        return 0;
>> +    }
>> +#else
>> +    return -2;
>> +#endif
> 
> Is it better to define the below somewhere else?
> 
> #ifndef CONFIG_HAVE_GET_MEMORY_MAPPING
> static inline int qemu_get_guest_memory_mapping(MemoryMappingList *list)
> {
> 	return -2;
> }
> #endif

Yes

Thanks
Wen Congyang

> 
> Thanks.
> HATAYAMA, Daisuke
> 
>