From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] ASoC: omap-mcbsp: Use DMA packet mode for non mono streams on OMAP3+
Date: Fri, 16 Mar 2012 09:00:12 +0200 [thread overview]
Message-ID: <4F62E4FC.1020303@bitmer.com> (raw)
In-Reply-To: <1331807834-25675-2-git-send-email-peter.ujfalusi@ti.com>
On 03/15/2012 12:37 PM, Peter Ujfalusi wrote:
> Take the DMA packet mode into use when the McBSP is configured in element
> dma_op_mode if the stream is not mono.
> In this way we transfer one sample from/to McBSP FIFO upon DMA request.
> This change only affects OMAP3+ versions, where the McBSP ports have FIFO.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> sound/soc/omap/omap-mcbsp.c | 30 +++++++++++++++++-------------
> 1 files changed, 17 insertions(+), 13 deletions(-)
>
Out of curiosity, I guess this will decrease a memory bus or DMA
controller load a bit. Can you see any difference with the SW tools
(top, etc) under some system load or do you need some on-chip
observability to be able to measure effect of this transfer pattern change?
Just willing to learn here :-)
--
Jarkko
next prev parent reply other threads:[~2012-03-16 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 10:37 [PATCH 0/2] ASoC: omap-mcbsp: dma_op_mode changes Peter Ujfalusi
2012-03-15 10:37 ` [PATCH 1/2] ASoC: omap-mcbsp: Use DMA packet mode for non mono streams on OMAP3+ Peter Ujfalusi
2012-03-16 7:00 ` Jarkko Nikula [this message]
2012-03-16 12:06 ` Peter Ujfalusi
2012-03-15 10:37 ` [PATCH 2/2] ASoC: omap-mcbsp: Remove unused FRAME dma_op_mode Peter Ujfalusi
2012-03-15 12:22 ` [PATCH 0/2] ASoC: omap-mcbsp: dma_op_mode changes Mark Brown
2012-03-16 6:29 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F62E4FC.1020303@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.