From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
jbottomley@parallels.com, linux-scsi@vger.kernel.org,
Huajun Li <huajun.li.lee@gmail.com>,
Axel Theilmann <theilmann@pre-sense.de>,
linux-kernel@vger.kernel.org
Subject: Re: Yet another hot unplug NULL pointer dereference (was Re: status of oops in sd_revalidate_disk?)
Date: Fri, 16 Mar 2012 17:58:35 +0900 [thread overview]
Message-ID: <4F6300BB.9060503@ce.jp.nec.com> (raw)
In-Reply-To: <4F5F8D82.2040704@acm.org>
Hi,
On 03/14/12 03:10, Bart Van Assche wrote:
> Now that I've had some more time to think about this: has anyone
> considered to hold a reference on the SCSI host instead of the SCSI
> device as long as sd_probe_async() is active ? If sd_prep_fn() can ever
> see a NULL queuedata pointer then that means that
> scsi_host_dev_release() can get invoked while sd_prep_fn() is running.
Holding a host reference does not help, I think.
It does not stop __scsi_remove_device() setting NULL
to sdev's q->queuedata.
So, while there might be another race between sd_probe_async
and scsi_host_remove, I believe your "[PATCH] Fix device
removal NULL pointer dereference" still makes sense.
> That doesn't look correct to me.
--
Jun'ichi Nomura, NEC Corporation
next prev parent reply other threads:[~2012-03-16 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 17:59 status of oops in sd_revalidate_disk? Axel Theilmann
2011-12-21 14:12 ` Huajun Li
2011-12-25 20:58 ` Yet another hot unplug NULL pointer dereference (was Re: status of oops in sd_revalidate_disk?) Stefan Richter
2011-12-27 10:21 ` Axel Theilmann
2011-12-27 10:21 ` Axel Theilmann
2011-12-27 13:40 ` Stefan Richter
2012-02-14 11:34 ` Jun'ichi Nomura
2012-02-14 11:54 ` Bart Van Assche
2012-02-14 13:38 ` Stefan Richter
2012-02-14 19:11 ` Bart Van Assche
2012-02-15 2:26 ` Jun'ichi Nomura
2012-02-15 11:29 ` Bart Van Assche
2012-02-16 1:04 ` Jun'ichi Nomura
2012-03-13 18:10 ` Bart Van Assche
2012-03-16 8:58 ` Jun'ichi Nomura [this message]
2012-03-16 18:53 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6300BB.9060503@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=bvanassche@acm.org \
--cc=huajun.li.lee@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=theilmann@pre-sense.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.