From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S8Tz9-00047V-0G
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 06:03:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S8TyU-0007hr-KC
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 06:02:10 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33471 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S8TyU-0007gy-BB
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 06:01:30 -0400
Message-ID: <4F630F77.8000107@suse.de>
Date: Fri, 16 Mar 2012 11:01:27 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1324998680-16003-1-git-send-email-avi@redhat.com>
	<4EF9EF17.4050703@suse.de> <4F33F23D.9000606@suse.de>
	<4F33F6A2.50500@redhat.com>
In-Reply-To: <4F33F6A2.50500@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] softfloat: fix for C99
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Lee Essen <lee.essen@nowonline.co.uk>, Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>

Am 09.02.2012 17:38, schrieb Avi Kivity:
> On 02/09/2012 06:20 PM, Andreas F=E4rber wrote:
>> Am 27.12.2011 17:15, schrieb Andreas F=E4rber:
>>> Am 27.12.2011 16:11, schrieb Avi Kivity:
>>>> C99 appears to consider compound literals as non-constants, and comp=
lains
>>>> when they are used in static initializers.  Switch to ordinary initi=
alizer
>>>> syntax.
>>>>
>>
>> Reported-by: Andreas F=E4rber <andreas.faerber@web.de>
>>
>>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>>
>>> Acked-by: Andreas F=E4rber <afaerber@suse.de>
>>>
>>> For the record, tested with --extra-cflags=3D-std=3Dgnu99.
>>>
>>>> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
>>>> index c5e2dab..4902450 100644
>>>> --- a/fpu/softfloat-specialize.h
>>>> +++ b/fpu/softfloat-specialize.h
>>>> @@ -89,8 +89,8 @@ const float64 float64_default_nan =3D const_float6=
4(LIT64( 0xFFF8000000000000 ));
>>>>  #define floatx80_default_nan_low  LIT64( 0xC000000000000000 )
>>>>  #endif
>>>> =20
>>>> -const floatx80 floatx80_default_nan =3D make_floatx80(floatx80_defa=
ult_nan_high,
>>>> -                                                    floatx80_defaul=
t_nan_low);
>>>> +const floatx80 floatx80_default_nan
>>>> +    =3D make_floatx80_init(floatx80_default_nan_high, floatx80_defa=
ult_nan_low);
>>>
>>> Calling it init_floatx80 would avoid the line break, but I'm okay wit=
h
>>> it either way.
>>
>> Ping! Avi, you didn't indicate whether you were going to simplify this
>> patch or whether you're waiting for someone to apply it as is?
>>
>=20
> Actually I forgot all about it.  If everyone's okay with it as is I'd
> like it to be applied, otherwise I'll respin.  Copying some maintainers
> completely at random.

Ping?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg