From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8W3D-0001EJ-4W for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:14:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8W36-0001QB-Hj for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:14:30 -0400 Received: from mout.web.de ([212.227.15.4]:63983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8W36-0001Pz-8P for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:14:24 -0400 Message-ID: <4F632E9E.9020006@web.de> Date: Fri, 16 Mar 2012 13:14:22 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1087EBB0-5CF0-49F1-971F-EE8ADC5E06DB@nowonline.co.uk> In-Reply-To: <1087EBB0-5CF0-49F1-971F-EE8ADC5E06DB@nowonline.co.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] configure to set shell type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lee Essen Cc: qemu-devel@nongnu.org Am 16.03.2012 13:02, schrieb Lee Essen: > Adds support to configure for controlling which shell to use, defaults to "sh" as before > but adds "bash" for Solaris/Illumos builds. Plus ensures that tracetool is called with a > shell. > > Signed-off-by: Lee Essen > > -- > > configure | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index afe7395..860c15d 100755 > --- a/configure > +++ b/configure > @@ -101,6 +101,7 @@ audio_win_int="" > cc_i386=i386-pc-linux-gnu-gcc > libs_qga="" > debug_info="yes" > +shell="sh" This looks reasonable. > > target_list="" > > @@ -442,6 +443,7 @@ SunOS) > # have to select again, because `uname -m` returns i86pc > # even on an x86_64 box. > solariscpu=`isainfo -k` > + shell="bash" Are you sure this is safe for Solaris 9+? In https://bugs.launchpad.net/qemu/+bug/636315 we concluded that /usr/xpg4/bin/sh were the best choice of POSIX-compliant shell provided on Solaris 10. Blue's script fixes were never applied I believe... > if test "${solariscpu}" = "amd64" ; then > cpu="x86_64" > fi > @@ -1097,7 +1099,7 @@ echo " --disable-docs disable documentation build" > echo " --disable-vhost-net disable vhost-net acceleration support" > echo " --enable-vhost-net enable vhost-net acceleration support" > echo " --enable-trace-backend=B Set trace backend" > -echo " Available backends:" $("$source_path"/scripts/tracetool --list-backends) > +echo " Available backends:" $($shell "$source_path"/scripts/tracetool --list-backends) > echo " --with-trace-file=NAME Full PATH,NAME of file to store traces" > echo " Default:trace-" > echo " --disable-spice disable spice" > @@ -2654,7 +2656,7 @@ fi > ########################################## > # check if trace backend exists > > -sh "$source_path/scripts/tracetool" "--$trace_backend" --check-backend > /dev/null 2> /dev/null > +$shell "$source_path/scripts/tracetool" "--$trace_backend" --check-backend > /dev/null 2> /dev/null > if test "$?" -ne 0 ; then > echo > echo "Error: invalid trace backend" > @@ -3358,6 +3360,7 @@ echo "LIBS+=$LIBS" >> $config_host_mak > echo "LIBS_TOOLS+=$libs_tools" >> $config_host_mak > echo "EXESUF=$EXESUF" >> $config_host_mak > echo "LIBS_QGA+=$libs_qga" >> $config_host_mak > +echo "SHELL=$shell" >> $config_host_mak Why? > > # generate list of library paths for linker script > Andreas