From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WOJ-0006pK-V8
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:36:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WOF-0005LW-9Q
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:36:19 -0400
Received: from mout.web.de ([212.227.15.3]:51115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WOF-0005LO-08
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:36:15 -0400
Message-ID: <4F6333BB.8020905@web.de>
Date: Fri, 16 Mar 2012 13:36:11 +0100
From: =?windows-1252?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1087EBB0-5CF0-49F1-971F-EE8ADC5E06DB@nowonline.co.uk>
	<4F632E9E.9020006@web.de>
	<0CFFD8B6-FCF3-44BF-87E0-44729ED219B9@nowonline.co.uk>
In-Reply-To: <0CFFD8B6-FCF3-44BF-87E0-44729ED219B9@nowonline.co.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/5] configure to set shell type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: qemu-devel@nongnu.org

Am 16.03.2012 13:20, schrieb Lee Essen:
> 
> On 16 Mar 2012, at 12:14, Andreas Färber wrote:
> 
>> Am 16.03.2012 13:02, schrieb Lee Essen:
>>>
>>> +echo "SHELL=$shell" >> $config_host_mak
>>
>> Why?
>>
> 
> See patch 2/7 … there are several calls to tracetool that hardcode "sh" in the Makefile … again if
> the better solution is removing the bash requirement then this problem goes away completely.

My point is, there is already use of $(SHELL) in Makefile. So why do you
need to explicitly set it here? Such things need to be explained in the
commit message. Was the variable being used unassigned? Or are you
trying to use a non-GNU make?

The concept of using $(SHELL) in make seems valid. Dunno if there is an
easier, built-in way to execute a script in the current shell than
hardcoding some executable name that needs to be in the $PATH?

Andreas