From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54357)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WVy-0004m3-Mh
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:44:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WVt-0006tm-Gx
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:44:14 -0400
Received: from mout.web.de ([212.227.15.3]:55277)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1S8WVt-0006tU-7p
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 08:44:09 -0400
Message-ID: <4F633595.5060608@web.de>
Date: Fri, 16 Mar 2012 13:44:05 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk>
In-Reply-To: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Am 16.03.2012 13:29, schrieb Lee Essen:
> Signed-off-by: Lee Essen <lee.essen@nowonline.co.uk>
>
> ---
>
>  scripts/tracetool |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/tracetool b/scripts/tracetool
> index 65bd0a1..2e43d05 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracetool
> @@ -123,7 +123,7 @@ get_argc()
>  # Get the format string including double quotes for a trace event
>  get_fmt()
>  {
> -    puts "${1#*)}"
> +    puts "${1#*}"
>  }
>  
>  linetoh_begin_nop()
>
Cc'ing the trace maintainer. I assume Lee forgot to look up the
maintainer, but Stefan, my checking MAINTAINERS indicates tracetool is
missing in the Tracing section too. Could you add it please?

Not being a shell expert I can't judge what this is actually trying to
do. Note that there is also an effort underway to rewrite tracetool as
tracetool.py.

Andreas