From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input
Date: Fri, 16 Mar 2012 14:18:11 +0100 [thread overview]
Message-ID: <4F633D93.4050701@siemens.com> (raw)
In-Reply-To: <4F633D37.60806@us.ibm.com>
On 2012-03-16 14:16, Anthony Liguori wrote:
> On 03/16/2012 07:25 AM, Jan Kiszka wrote:
>> Once a chr frontend is able to receive input again, we need to inform
>> the io-thread about this fact. Otherwise, main_loop_wait may continue to
>> select without the related backend file descriptor in its set. This can
>> cause high input latencies if only low-rate events arrive otherwise.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>
> I'm not nacking this patch, but please note that this is a band-aid as not all
> char devices actually use qemu_chr_accept_input().
Then they have to be fixed. :)
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-03-16 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:25 [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input Jan Kiszka
2012-03-16 13:16 ` Anthony Liguori
2012-03-16 13:18 ` Jan Kiszka [this message]
2012-03-29 12:19 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F633D93.4050701@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=marek.vasut@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.