Re: [xen-unstable test] 12250: regressions - FAIL

[Andrew Cooper <andrew.cooper3@citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On 16/03/12 14:53, xen.org wrote:
> flight 12250 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/12250/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-i386-oldkern            4 xen-build                 fail REGR. vs. 12249
>  build-i386                    4 xen-build                 fail REGR. vs. 12249

This is the fault of one of my patches.  Fix is attached.

I had been doing my testing with a debug patch on the end of the
series.  I tested the 64bit build for every patch, but only the 32bit
build at the end of the series.  I will take more care in future.

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


[-- Attachment #2: KEXEC-fix-i386-build.patch --]
[-- Type: text/x-patch, Size: 719 bytes --]

# HG changeset patch
# Parent 3481a36b5f865cd221da2b580ebf0ab3596e9f1d
Fix printing of paddr_t's in 32bit mode.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff -r 3481a36b5f86 xen/common/kexec.c
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -207,8 +207,8 @@ static void __init parse_crashinfo_maxad
     if ( (addr = parse_size_and_unit(str, NULL)) )
         crashinfo_maxaddr = addr;
     else
-        printk("Unable to parse crashinfo_maxaddr. Defaulting to %p\n",
-               (void*)crashinfo_maxaddr);
+        printk("Unable to parse crashinfo_maxaddr. Defaulting to %"PRIpaddr"\n",
+               crashinfo_maxaddr);
 }
 custom_param("crashinfo_maxaddr", parse_crashinfo_maxaddr);
 

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel