All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: "Andreas Färber" <andreas.faerber@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm
Date: Fri, 16 Mar 2012 19:15:04 +0100	[thread overview]
Message-ID: <4F638328.7000309@redhat.com> (raw)
In-Reply-To: <0A468378-02CE-4CEE-868C-3DE8B34C3AF2@nowonline.co.uk>

Il 16/03/2012 18:25, Lee Essen ha scritto:
> Correct … but actually this raises another question … why create a separate pointer to kvm_state…
> 
>     KVMState *s = kvm_state;
> 
> … why not just use kvm_state throughout the function?
> 
> This seems to be a common approach in many of the functions in kvm-all.c … is there a reason?

It's historical due to the way things were done in the qemu-kvm fork.
It was done this way in order to let qemu.git and qemu-kvm.git share a
bit more code, IIUC.

Paolo

  reply	other threads:[~2012-03-16 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16  9:23 [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm Lee Essen
2012-03-16 10:15 ` Andreas Färber
2012-03-16 11:56 ` Paolo Bonzini
2012-03-16 17:25   ` Lee Essen
2012-03-16 18:15     ` Paolo Bonzini [this message]
2012-03-16 13:14 ` Jan Kiszka
2012-03-16 13:46   ` Lee Essen
2012-03-16 16:28     ` Paolo Bonzini
2012-03-16 17:15       ` Lee Essen
2012-03-17  9:00     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F638328.7000309@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=andreas.faerber@web.de \
    --cc=lee.essen@nowonline.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.