All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] ath9k:  Support ethtool getstats api.
Date: Fri, 16 Mar 2012 11:37:13 -0700	[thread overview]
Message-ID: <4F638859.8060809@candelatech.com> (raw)
In-Reply-To: <4F637325.2020205@openwrt.org>

On 03/16/2012 10:06 AM, Felix Fietkau wrote:

>>> Most of the PHY error counters aren't even tracked by the hw, nothing in
>>> the driver enables their use.
>>
>> Well, any reason we cannot enable those?
> The hardware has a limited number of counter registers available for
> tracking PHY errors. Enabling PHY errors to be reported via DMA wastes
> tons of precious CPU cycles.

Am I correct in assuming that these are the only phy-errors that
the driver can currently report?

#define AR_PHY_ERR_DCHIRP      0x00000008
#define AR_PHY_ERR_RADAR       0x00000020
#define AR_PHY_ERR_OFDM_TIMING 0x00020000
#define AR_PHY_ERR_CCK_TIMING  0x02000000

With regard to DMA resources, do you mean that the
waste is in having the NIC receive the packets that
would otherwise be filtered?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2012-03-16 18:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 23:20 [PATCH 1/4] cfg80211: Add framework to support ethtool stats greearb
2012-03-15 23:20 ` [PATCH 2/4] mac80211: Support getting sta_info stats via ethtool greearb
2012-03-15 23:20 ` [PATCH 3/4] mac80211: Framework to get wifi-driver " greearb
2012-03-16  8:54   ` Johannes Berg
2012-03-15 23:20 ` [PATCH 4/4] ath9k: Support ethtool getstats api greearb
2012-03-16 15:06   ` Felix Fietkau
2012-03-16 16:23     ` Ben Greear
2012-03-16 16:36       ` Felix Fietkau
2012-03-16 16:51         ` Ben Greear
2012-03-16 17:06           ` Felix Fietkau
2012-03-16 18:37             ` Ben Greear [this message]
2012-03-16  8:50 ` [PATCH 1/4] cfg80211: Add framework to support ethtool stats Johannes Berg
2012-03-16 10:05 ` Florian Fainelli
2012-03-16 15:06   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F638859.8060809@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.