From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8cvl-0003Yz-0H for qemu-devel@nongnu.org; Fri, 16 Mar 2012 15:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8cvi-00063j-Mo for qemu-devel@nongnu.org; Fri, 16 Mar 2012 15:35:16 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:56500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8cvi-00063c-Et for qemu-devel@nongnu.org; Fri, 16 Mar 2012 15:35:14 -0400 Message-ID: <4F6395EE.6080109@msgid.tls.msk.ru> Date: Fri, 16 Mar 2012 23:35:10 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1331845217-21705-1-git-send-email-mjt@msgid.tls.msk.ru> <1331845217-21705-6-git-send-email-mjt@msgid.tls.msk.ru> <4F636825.2090007@codemonkey.ws> In-Reply-To: <4F636825.2090007@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv4 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org On 16.03.2012 20:19, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> Similar to >> qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, >> int c, size_t bytes); >> the new prototype is: >> qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, >> const void *buf, size_t bytes); >> >> The processing starts at offset bytes within qiov. >> >> This way, we may copy a bounce buffer directly to >> a middle of qiov. >> >> This is exactly the same function as iov_from_buf() from >> iov.c, so use the existing implementation and rename it >> to qemu_iovec_from_buf() to be shorter and to match the >> utility function. >> >> As with utility implementation, we now assert that the >> offset is inside actual iovec. Nothing changed for >> current callers, because `offset' parameter is new. >> >> While at it, stop using "bounce-qiov" in block/qcow2.c >> and copy decrypted data directly from cluster_data >> instead of recreating a temp qiov for doing that >> (Cc'ing kwolf for this change). >> >> Signed-off-by: Michael Tokarev >> Cc: Kevin Wolf > > Kevin, please Ack. Kevin already reviewed the (previous version which hasn't changed in the block layer) patch: http://thread.gmane.org/gmane.comp.emulators.qemu/140817/focus=141013 but since he didn't include any Signed-off-by/Reviewed-by I left it as-is. Thanks, /mjt